1461889 - [e2e-tests] Remove test_that_only_(plugin, browser)_reports_have_(plugin, browser)_icon tests

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

In the e2e-tests world, the 3rd and 4th most-expensive tests (in terms of execution times) are:

* test_that_only_plugin_reports_have_plugin_icon @ ~ 45 seconds
* test_that_only_browser_reports_have_browser_icon @ 42 seconds

Doesn't seem worth it, and it's an easy removable for both the tests and their page objects.

Tests: https://github.com/mozilla-services/socorro/blob/e8b1c040ccbbb705b978cc8bbcfc540aeb90eab7/e2e-tests/tests/test_crash_reports.py#L147-L189

Page objects:

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Oops; bitten by the old "hit the Enter key too soon" bug!

(Page objects): https://github.com/mozilla-services/socorro/blob/e8b1c040ccbbb705b978cc8bbcfc540aeb90eab7/e2e-tests/pages/crash_stats_top_crashers_page.py#L117-L137 - just the lines with "browser" and "plugin," there, since I'm too lazy to figure out the perfect line-specific permalink in GitHub.

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: pr 4447: Bug 1461889 - [e2e-tests] Remove test_that_only_(plugin, browser)_reports_have_(plugin, browser)_icon tests

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/2a7d9bab3472b8fdbfd74f0647449ad761428dfa
Bug 1461889 - [e2e-tests] Remove test_that_only_(plugin, browser)_reports_have_(plugin, browser)_icon tests

https://github.com/mozilla-services/socorro/commit/42ab16f0129b6c2590baed1b0a6da6e440fd21c1
Merge pull request #4447 from stephendonner/remove-browser-plugin-icon-tests

Bug 1461889 - [e2e-tests] Remove test_that_only_(plugin, browser)_reports_have_(plugin, browser)_icon tests