1461912 - "Accessible Information Unavailable" message is displayed after enabling Accessibility Features

Status: VERIFIED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Accessible Information.gif

[Affected versions]:
Firefox 62.0a1 (BuildId:20180515220059).

[Affected platforms]:
Windows 10 64bit
macOS 10.12
Ubuntu 16.04 64bit

[Steps to reproduce]:
1. Launch Firefox.
2. Access the https://vk.com/ webpage.
3. Enable the Accessibility features.

[Expected result]:
Specific information related to the opened website is displayed.

[Actual result]:
"Accessible information Unavailable" is displayed under the "Properties" panel.

[Regression range]:
This seems to be a regression:

Last good revision: 7201982e0481cbc237a21756ef88827c4dcfb2c8
First bad revision: b3147109d3af0945ed9783d513b14ffe3d755df3

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=7201982e0481cbc237a21756ef88827c4dcfb2c8&tochange=b3147109d3af0945ed9783d513b14ffe3d755df3

[Additional information]:
For further information regarding this issue please observe the attached screencast.
Please note that this issue may occur by simply following the up mentioned steps or, additionally, you may have to disable/enable the accessibility feature a couple of times for this issue to occur.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Yura,

It seems that mozregression pointed out Bug 1441187 for causing this regression.

Can you please have a look?

Thanks!

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1461912 patch

Since as of bug 1441187 we now rely on stale state instead of busy to determine document readiness, we should not clear accessible actors cache on busy event, as it is done when accessible actor for document is created.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba4ce98ebac5
do not clear accessible actors cache when document becomes non-busy. r=pbro

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8977074 [details] [diff] [review]
1461912 patch

Approval Request Comment
[Feature/Bug causing the regression]: bug 1441187
[User impact if declined]: This along with bug 1441187 are high priority bugs for a11y panel devtool.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: STR are in the description.
[List of other uplifts needed for the feature/fix]: depends on bug 1441187
[Is the change risky?]: No
[Why is the change risky/not risky?]: This is a small change that makes the panel loading much more reliable.
[String changes made/needed]: None

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ba4ce98ebac5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8977074 [details] [diff] [review]
1461912 patch

Improvements for the a11y inspector. Approved for 61.0b8.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a375e2abdf85

Comment 8

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 62.0a1 (BuildId:20180523221148) and Firefox 61.0b8 (BuildId:20180524181234) on Windows 10 64bit, macOS 10.13.4 and Ubuntu 16.04 64bit.