Closed Bug 1461933 Opened 2 years ago Closed 2 years ago

Avoid massive dependency to ServoBindings.h

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

Details

Attachments

(1 file)

Nowadays we still touch ServoBindings.h (as well as ServoBindingList.h) regularly, also function definitions generally take more cycle to settle down than data structs even in local development, so I believe it is better not to have massive dependencies to that file.

Currently that file is included by ComputedStyleInlines.h, which is included by nsIFrame.h, which affects lots of files. I'd like to remove it from such dependency.
I apologize that this patch can definitely be split into finer bits... but I'm too lazy :)
Comment on attachment 8976089 [details]
Bug 1461933 - Remove ServoBindings.h from ComputedStyleInline.h.

https://reviewboard.mozilla.org/r/244282/#review250248

Looks good, thank you :)
Attachment #8976089 - Flags: review?(emilio) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce7798f62689
Remove ServoBindings.h from ComputedStyleInline.h. r=emilio
https://hg.mozilla.org/mozilla-central/rev/ce7798f62689
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.