1461933 - Avoid massive dependency to ServoBindings.h

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

Nowadays we still touch ServoBindings.h (as well as ServoBindingList.h) regularly, also function definitions generally take more cycle to settle down than data structs even in local development, so I believe it is better not to have massive dependencies to that file.

Currently that file is included by ComputedStyleInlines.h, which is included by nsIFrame.h, which affects lots of files. I'd like to remove it from such dependency.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1461933 - Remove ServoBindings.h from ComputedStyleInline.h.

For doing this, ServoComputedData is split into separate files, so that
files don't need to include ServoBindings.h just for accessing style
structs from ComputedStyles.

Review commit: https://reviewboard.mozilla.org/r/244282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244282/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

I apologize that this patch can definitely be split into finer bits... but I'm too lazy :)

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8976089 [details]
Bug 1461933 - Remove ServoBindings.h from ComputedStyleInline.h.

https://reviewboard.mozilla.org/r/244282/#review250248

Looks good, thank you :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce7798f62689
Remove ServoBindings.h from ComputedStyleInline.h. r=emilio

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ce7798f62689