Closed Bug 1461948 Opened 6 years ago Closed 6 years ago

TypedObject adjustments to support Wasm structure types

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: lth, Assigned: lth)

References

Details

Attachments

(5 files)

In short order I've accumulated a number of adjustments to the TO system including some cleanup.  This does not perturb existing functionality and can just land; in any case we'll want this if we want to base Wasm structure types on something like TO.
Attachment #8976109 - Flags: review?(till)
Attachment #8976110 - Flags: review?(till)
Attachment #8976111 - Flags: review?(till)
Attachment #8976112 - Flags: review?(till)
Attachment #8976113 - Flags: review?(till)
Comment on attachment 8976109 [details] [diff] [review]
bug1461948-remove-length-parameter.patch

Review of attachment 8976109 [details] [diff] [review]:
-----------------------------------------------------------------

Let's just remove the ifdef'd functions: they're trivial to re-implement, and leaving them in runs a high risk of them being forgotten and still be re-implemented.
Attachment #8976109 - Flags: review?(till) → review+
Comment on attachment 8976112 [details] [diff] [review]
bug1461948-abstract-inline-decision.patch

Review of attachment 8976112 [details] [diff] [review]:
-----------------------------------------------------------------

I share this opinion :)
Attachment #8976112 - Flags: review?(till) → review+
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7bfcf62f6807
Remove redundant length parameter for TypedObject constructor. r=till
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9de6329f9ad
Abstract the inline/outline TypedObject decision. r=till
Keywords: leave-open
Comment on attachment 8976110 [details] [diff] [review]
bug1461948-factor-struct-constructor.patch

Review of attachment 8976110 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8976110 - Flags: review?(till) → review+
Comment on attachment 8976111 [details] [diff] [review]
bug1461948-generalize-struct-layout.patch

Review of attachment 8976111 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8976111 - Flags: review?(till) → review+
Comment on attachment 8976113 [details] [diff] [review]
bug1461948-uncouple-reference-type.patch

Review of attachment 8976113 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #8976113 - Flags: review?(till) → review+
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6cd4f48162d
Factor the TypedObject struct type constructor. r=till
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8434494445c
Generalize and abstract TypedObject field layout algorithm. r=till
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d069afa41fa
Uncouple ReferenceType from TypedObject's ReferenceTypeDescr. r=till
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/e6cd4f48162d
https://hg.mozilla.org/mozilla-central/rev/c8434494445c
https://hg.mozilla.org/mozilla-central/rev/1d069afa41fa
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.