Closed
Bug 1461948
Opened 6 years ago
Closed 6 years ago
TypedObject adjustments to support Wasm structure types
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: lth, Assigned: lth)
References
Details
Attachments
(5 files)
9.36 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
6.29 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
5.58 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
3.42 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
25.98 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
In short order I've accumulated a number of adjustments to the TO system including some cleanup. This does not perturb existing functionality and can just land; in any case we'll want this if we want to base Wasm structure types on something like TO.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8976109 -
Flags: review?(till)
Assignee | ||
Updated•6 years ago
|
Attachment #8976110 -
Flags: review?(till)
Assignee | ||
Updated•6 years ago
|
Attachment #8976111 -
Flags: review?(till)
Assignee | ||
Updated•6 years ago
|
Attachment #8976112 -
Flags: review?(till)
Assignee | ||
Updated•6 years ago
|
Attachment #8976113 -
Flags: review?(till)
Comment 6•6 years ago
|
||
Comment on attachment 8976109 [details] [diff] [review] bug1461948-remove-length-parameter.patch Review of attachment 8976109 [details] [diff] [review]: ----------------------------------------------------------------- Let's just remove the ifdef'd functions: they're trivial to re-implement, and leaving them in runs a high risk of them being forgotten and still be re-implemented.
Attachment #8976109 -
Flags: review?(till) → review+
Comment 7•6 years ago
|
||
Comment on attachment 8976112 [details] [diff] [review] bug1461948-abstract-inline-decision.patch Review of attachment 8976112 [details] [diff] [review]: ----------------------------------------------------------------- I share this opinion :)
Attachment #8976112 -
Flags: review?(till) → review+
Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7bfcf62f6807 Remove redundant length parameter for TypedObject constructor. r=till https://hg.mozilla.org/integration/mozilla-inbound/rev/d9de6329f9ad Abstract the inline/outline TypedObject decision. r=till
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Comment 9•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7bfcf62f6807 https://hg.mozilla.org/mozilla-central/rev/d9de6329f9ad
Comment 10•6 years ago
|
||
Comment on attachment 8976110 [details] [diff] [review] bug1461948-factor-struct-constructor.patch Review of attachment 8976110 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8976110 -
Flags: review?(till) → review+
Comment 11•6 years ago
|
||
Comment on attachment 8976111 [details] [diff] [review] bug1461948-generalize-struct-layout.patch Review of attachment 8976111 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8976111 -
Flags: review?(till) → review+
Comment 12•6 years ago
|
||
Comment on attachment 8976113 [details] [diff] [review] bug1461948-uncouple-reference-type.patch Review of attachment 8976113 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8976113 -
Flags: review?(till) → review+
Comment 13•6 years ago
|
||
Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e6cd4f48162d Factor the TypedObject struct type constructor. r=till https://hg.mozilla.org/integration/mozilla-inbound/rev/c8434494445c Generalize and abstract TypedObject field layout algorithm. r=till https://hg.mozilla.org/integration/mozilla-inbound/rev/1d069afa41fa Uncouple ReferenceType from TypedObject's ReferenceTypeDescr. r=till
Assignee | ||
Updated•6 years ago
|
Keywords: leave-open
Comment 14•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e6cd4f48162d https://hg.mozilla.org/mozilla-central/rev/c8434494445c https://hg.mozilla.org/mozilla-central/rev/1d069afa41fa
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•