Closed Bug 1461954 Opened 6 years ago Closed 6 years ago

Fix nsBulletFrame's image request code.

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(1 file)

      No description provided.
I really wonder if DeregisterImageRequest's bool argument is really useful. Most people forget about the request right after, so it'd be a bug if it somehow remained true after calling it.

Also, RegisterImageRequest's bool doesn't really seem useful either, it's true iff aRequest is true.

Should we remove them? WDYT Timothy?
Flags: needinfo?(tnikkel)
Priority: -- → P3
Comment on attachment 8976108 [details]
Bug 1461954: Fix nsBulletFrame's image request registration code.

https://reviewboard.mozilla.org/r/244300/#review252700
Attachment #8976108 - Flags: review?(tnikkel) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/aae6a29b4ca3
Fix nsBulletFrame's image request registration code. r=tnikkel
https://hg.mozilla.org/mozilla-central/rev/aae6a29b4ca3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: needinfo?(tnikkel)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: