Closed Bug 1461997 Opened 2 years ago Closed 2 years ago

Create an ESLint rule to prevent usages of Assert.throws/rejects without an 'expected' argument

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(4 files)

See bug 1452706 for the background, this is for creating the rule and initial whitelist.
Comment on attachment 8976292 [details]
Bug 1461997 - Enable ESLint rule mozilla/require-expected-throws-or-rejects for browser/components.

https://reviewboard.mozilla.org/r/244470/#review250532

rs=me
Attachment #8976292 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8976456 [details]
Bug 1461997 - Remove unused feeds xpcshell-test that were missed being removed in bug 1420622.

https://reviewboard.mozilla.org/r/244578/#review250644
Attachment #8976456 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 8976291 [details]
Bug 1461997 - Create a rule to prevent usages of Assert.throws/rejects without an 'expected' argument.

https://reviewboard.mozilla.org/r/244468/#review250784
Attachment #8976291 - Flags: review?(dtownsend) → review+
Comment on attachment 8976305 [details]
Bug 1461997 - Add an ESLint rule to ensure that Assert.rejects is preceeded by await.

https://reviewboard.mozilla.org/r/244472/#review250786
Attachment #8976305 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74a8b71fcdac
Create a rule to prevent usages of Assert.throws/rejects without an 'expected' argument. r=mossop
https://hg.mozilla.org/integration/autoland/rev/42e510b46e6c
Remove unused feeds xpcshell-test that were missed being removed in bug 1420622. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/2f23cf70c176
Enable ESLint rule mozilla/require-expected-throws-or-rejects for browser/components. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/672e132cb4ad
Add an ESLint rule to ensure that Assert.rejects is preceeded by await. r=mossop
Summary: Create a rule to prevent usages of Assert.throws/rejects without an 'expected' argument → Create an ESLint rule to prevent usages of Assert.throws/rejects without an 'expected' argument
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.