Remove migrateRegionPrefs from search service

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Trunk
Firefox 62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
We have a function migrateRegionPrefs that does migration based on the old isUS/countryCode prefs.

In Firefox 57, we did a one time reset of all these prefs (and we will do it for all old users that upgrade)

https://searchfox.org/mozilla-central/source/browser/components/nsBrowserGlue.js#2075

So there are no users that have these preferences anymore.

We should get rid of this unused code.

At the same time, we should get rid of all references to the old .isUS preference.

It's never set anymore and it is not used except in migration.
Comment hidden (mozreview-request)
Assignee

Updated

a year ago
Blocks: 1462015
Comment hidden (mozreview-request)

Comment 3

a year ago
mozreview-review
Comment on attachment 8976183 [details]
Bug 1462010 - Remove unused migrateRegionPrefs and isUS preference.

https://reviewboard.mozilla.org/r/244368/#review250566
Attachment #8976183 - Flags: review?(adw) → review+
Comment hidden (mozreview-request)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 541b24452ba79cc2d863816bdca22fa895fa5e36 -d d53f1330f08c: rebasing 464090:541b24452ba7 "Bug 1462010 - Remove unused migrateRegionPrefs and isUS preference. r=adw" (tip)
merging testing/profiles/common/user.js
merging testing/profiles/reftest/user.js and layout/tools/reftest/reftest-preferences.js to testing/profiles/reftest/user.js
warning: conflicts while merging testing/profiles/common/user.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/profiles/reftest/user.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 46fb193b8f55080b4191841e879d5a623fc35269 -d 18b348f11483: rebasing 464091:46fb193b8f55 "Bug 1462010 - Remove unused migrateRegionPrefs and isUS preference. r=adw" (tip)
merging testing/profiles/common/user.js
merging testing/profiles/reftest/user.js and layout/tools/reftest/reftest-preferences.js to testing/profiles/reftest/user.js
warning: conflicts while merging testing/profiles/common/user.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging testing/profiles/reftest/user.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request)

Comment 9

a year ago
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/e993aa150201
Remove unused migrateRegionPrefs and isUS preference. r=adw

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e993aa150201
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.