Closed
Bug 1462149
Opened 6 years ago
Closed 6 years ago
Use &brandShortName; instead of hard-coded "Firefox" in strings for the payments UI
Categories
(Firefox :: WebPayments UI, enhancement, P1)
Firefox
WebPayments UI
Tracking
()
RESOLVED
FIXED
Firefox 62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: sfoster, Assigned: MattN)
References
Details
(Whiteboard: [webpayments])
Attachments
(1 file)
Some strings currently hard-code "Firefox". Once we have our final localization solution in place (Fluent) for the payments UI, these should be fixed to use &brandShortName;
|
Assignee | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Whiteboard: [webpayments] → [webpayments] [triage]
|
|
||
Updated•6 years ago
|
Whiteboard: [webpayments] [triage] → [webpayments]
|
|
Assignee | |
Comment 1•6 years ago
|
||
Moving to reserve since this depends on Fluent support which may not be ready for M3 and this doesn't need to block enabling on Nightly.
Priority: P2 → P3
Whiteboard: [webpayments] → [webpayments-reserve]
|
||
Comment 2•6 years ago
|
||
(In reply to Matthew N. [:MattN] (PM if requests are blocking you) from comment #1) > Moving to reserve since this depends on Fluent support which may not be > ready for M3 and this doesn't need to block enabling on Nightly. This doesn't really depend on Fluent, and we shouldn't expose strings with hard-coded Firefox if we plan to fix them later.
|
|
Assignee | |
Comment 3•6 years ago
|
||
(In reply to Francesco Lodolo [:flod][PTO May 17-20] from comment #2) > (In reply to Matthew N. [:MattN] (PM if requests are blocking you) from > comment #1) > > Moving to reserve since this depends on Fluent support which may not be > > ready for M3 and this doesn't need to block enabling on Nightly. > > This doesn't really depend on Fluent, and we shouldn't expose strings with > hard-coded Firefox if we plan to fix them later. Yeah, I guess you're correct due to unfixed security bug 467035.
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Priority: P3 → P1
Summary: Use &brandShortName instead of hard-coded "Firefox" in strings for the payments UI → Use &brandShortName; instead of hard-coded "Firefox" in strings for the payments UI
Whiteboard: [webpayments-reserve] → [webpayments]
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 5•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8979768 [details] Bug 1462149 - Use &brandShortName; instead of hard-coded Firefox in strings for the payments UI. https://reviewboard.mozilla.org/r/245914/#review252308 ::: browser/components/payments/res/paymentRequest.xhtml:8 (Diff revision 1) > - License, v. 2.0. If a copy of the MPL was not distributed with this > - file, You can obtain one at http://mozilla.org/MPL/2.0/. --> > <!DOCTYPE html [ > <!ENTITY % globalDTD SYSTEM "chrome://global/locale/global.dtd"> > %globalDTD; > + <!ENTITY % brandDTD SYSTEM "chrome://branding/locale/brand.dtd" > I thought this was going to be complicated?
Attachment #8979768 -
Flags: review?(sfoster) → review+
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/0c068d19e681 Use &brandShortName; instead of hard-coded Firefox in strings for the payments UI. r=sfoster
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0c068d19e681
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in
before you can comment on or make changes to this bug.
Description
•