Closed Bug 1462166 Opened 2 years ago Closed 2 years ago

Style Bookmark doorhanger buttons like panel footer buttons

Categories

(Firefox :: Theme, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
I copied the blue values from here so we're internally consistent, and because the mockup didn't have the hover and active values:

https://searchfox.org/mozilla-central/rev/5a744713370ec47969595e369fd5125f123e6d24/toolkit/themes/shared/popupnotification.inc.css#85-96
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attached image macOS Screenshot (obsolete) —
The patch doesn't look quite right on macOS.

Probably because of these bits: https://searchfox.org/mozilla-central/source/browser/themes/osx/browser.css#414-435
(In reply to Tim Nguyen :ntim from comment #3)
> Created attachment 8981756 [details]
> macOS Screenshot
> 
> The patch doesn't look quite right on macOS.
> 
> Probably because of these bits:
> https://searchfox.org/mozilla-central/source/browser/themes/osx/browser.
> css#414-435

Ah yes, I forgot about that stuff. Thanks.
Comment on attachment 8981399 [details]
Bug 1462166 - Style Bookmark doorhanger buttons like panel footer buttons.

https://reviewboard.mozilla.org/r/247520/#review254450

::: browser/themes/shared/places/editBookmarkPanel.inc.css:28
(Diff revision 2)
> +
> +.editBookmarkPanelBottomButton {
> +  flex: 1;
> +  -moz-appearance: none;
> +  margin: 0;
> +  padding: 1em;

Hm, the buttons in the mock-up are less tall, indeed they appear to be more or less as tall as the header.

Applying the patch, on Windows 10, they appear too tall and unbalanced. Could you please reduce the vertical padding a little bit, so the buttons are shorter and about the same height as the header?

::: browser/themes/shared/places/editBookmarkPanel.inc.css:48
(Diff revision 2)
> +  border-inline-end: 1px solid var(--panel-separator-color);
> +}
> +
> +.editBookmarkPanelBottomButton[default] {
> +  color: white;
> +  background-color: #0996f8;

nit: If these colors start being used across all the notification panels, it may be worth to evaluate moving them to vars
Attachment #8981399 - Flags: review?(mak77) → review+
Attachment #8981756 - Attachment is obsolete: true
Blocks: 1465927
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ea2e4c24e373
Style Bookmark doorhanger buttons like panel footer buttons. r=mak
https://hg.mozilla.org/mozilla-central/rev/ea2e4c24e373
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Depends on: 1474209
You need to log in before you can comment on or make changes to this bug.