1462227 - CSD titlebar rendering mode not enabled on Deepin desktop

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Gary Wang]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36

Steps to reproduce:

Simply open firefox on Deepin desktop (Deepin Desktop Enviroment)


Actual results:

CSD titlebar rendering mode not enabled, we can only see a normal titlebar.


Expected results:

CSD titlebar rendering mode should be enabled.

When launching firefox with the firefox.desktop file set as `Exec=env XDG_CURRENT_DESKTOP=GNOME /usr/lib/firefox/firefox %u`, the it works fine.

The XDG_CURRENT_DESKTOP is set as "Deepin" on Linux Deepin.

$ env | grep XDG_CURRENT_DESKTOP
XDG_CURRENT_DESKTOP=Deepin

So it seems we should add a line at https://hg.mozilla.org/mozilla-central/file/93443d36d4bd/widget/gtk/nsWindow.cpp#l7052 and check the `currentDesktop` value is "Deepin" or not.

Possible fix (untested, the bootstrap.py script for quick building firefox locally seems doesn't support this distro neither):

// Deepin Desktop Enviroment
} else if (strstr(currentDesktop, "Deepin") != nullptr) {
            sCSDSupportLevel = CSD_SUPPORT_SYSTEM;

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1462227 - Enable hiding system titlebar on Deepin desktop, r=jhorak

Comment 2

[Martin Stránský [:stransky] (ni? me)]

You can easily enable the titlebar by setting MOZ_GTK_TITLEBAR_DECORATION env value to "system" or "client" where "system" would be more suitable for you as it uses window manager decorations.

Comment 3

[Gary Wang]

(In reply to Martin Stránský [:stransky] from comment #2)
> You can easily enable the titlebar by setting MOZ_GTK_TITLEBAR_DECORATION
> env value to "system" or "client" where "system" would be more suitable for
> you as it uses window manager decorations.

Yeah that works, but since Firefox itself got other DE's built-in support, adding support for a Deepin Desktop Enviroment (DDE) is also a good idea imo.

xdg-utils provided by freedesktop is already support DDE (https://cgit.freedesktop.org/xdg/xdg-utils/tree/scripts/xdg-utils-common.in#n292 ), if firefox got it's built-in support, users who are using Linux Deepin or other distro with DDE support can use firefox's CSD titlebar out-of-the-box.

Comment 4

[Jan Horak [:jhorak]]

Comment on attachment 9003781 [details]
Bug 1462227 - Enable hiding system titlebar on Deepin desktop, r=jhorak

Jan Horak [:jhorak] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3a7f10f4e35
Enable hiding system titlebar on Deepin desktop, r=jhorak

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c3a7f10f4e35

Comment 7

[Mahmoud Elswerky]

thanks 
this worked for me for deepin desktop on deepin os and manjaro_deepin