Links in application panel empty screen don't work if DevTools are in a separate window

RESOLVED FIXED in Firefox 62

Status

enhancement
P3
normal
RESOLVED FIXED
Last year
23 hours ago

People

(Reporter: jdescottes, Assigned: ladybenko)

Tracking

(Blocks 1 bug)

61 Branch
Firefox 62
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

The links opening a new tab in the application panel should use devtools/client/shared/link.js
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Comment on attachment 8980337 [details]
Bug 1462232 - Links don't work if devtools are in a separate window.

https://reviewboard.mozilla.org/r/246490/#review252790

Looks good to me and works well, thanks Belén !
Could we add a test to make sure we don't regress this ?
Attachment #8980337 - Flags: review?(nchevobbe) → review+
Note if you want to add a test, the bet will be to test this with about:debugging, because the other links would trigger a network request which is not allowed in tests (or we need a way to update the URLs used to point to local test files instead of MDN links).
(In reply to Julian Descottes [:jdescottes][:julian] from comment #3)
> Note if you want to add a test, the bet will be to test this with
> about:debugging, because the other links would trigger a network request
> which is not allowed in tests (or we need a way to update the URLs used to
> point to local test files instead of MDN links).

We could only test the about:debugging link maybe ? That way we don't reach the network and we don't have to shim URL opening (that's what we do in the console).
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f5807715395d
Links don't work if devtools are in a separate window. r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/f5807715395d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.