1462232 - Links in application panel empty screen don't work if DevTools are in a separate window

Status: RESOLVED FIXED

(DevTools :: Application Panel, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

The links opening a new tab in the application panel should use devtools/client/shared/link.js

Comment 1

[Belén [:ladybenko]]

Attachment: Bug 1462232 - Links don't work if devtools are in a separate window.

Review commit: https://reviewboard.mozilla.org/r/246490/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246490/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8980337 [details]
Bug 1462232 - Links don't work if devtools are in a separate window.

https://reviewboard.mozilla.org/r/246490/#review252790

Looks good to me and works well, thanks Belén !
Could we add a test to make sure we don't regress this ?

Comment 3

[Julian Descottes [:jdescottes]]

Note if you want to add a test, the bet will be to test this with about:debugging, because the other links would trigger a network request which is not allowed in tests (or we need a way to update the URLs used to point to local test files instead of MDN links).

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Julian Descottes [:jdescottes][:julian] from comment #3)
> Note if you want to add a test, the bet will be to test this with
> about:debugging, because the other links would trigger a network request
> which is not allowed in tests (or we need a way to update the URLs used to
> point to local test files instead of MDN links).

We could only test the about:debugging link maybe ? That way we don't reach the network and we don't have to shim URL opening (that's what we do in the console).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5807715395d
Links don't work if devtools are in a separate window. r=nchevobbe

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/f5807715395d