1462266 - "Your New Tab has changed" message re-appears after calling `browser.runtime.reload()`

Status: UNCONFIRMED

(WebExtensions :: Frontend, defect, P3)

Description

[juraj.masiar]

Attachment: your_tab_has_changed.mp4

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180514150347

Steps to reproduce:

See the attachment video or:
1) install add-on overriding New Tab page
2) open New Tab page
3) click "Keep Changes"
4) open console and execute `browser.runtime.reload()`
5) open New tab


Actual results:

The message "Your New Tab has changed" is shown again, every time the code is executed.


Expected results:

The message should be shown only once.

Note that this behavior seems to be affecting only normally installed add-ons and temporary installed add-ons through about:debugging page are not affected...

Comment 1

[Andrew Swan [:aswan]]

browser.runtime.reload() is implemented as disable followed by enable.  And currently when an extension is disabled we reset the stored state about the notification so it is shown again when the extension is re-enabled.
Mark, any thoughts?

Comment 2

[Mark Striemer [:mstriemer]]

That's what I was thinking it was doing and that is unfortunate in this case. I'll leave my NI? and look into this some more.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hey Shane, would you mind to double-check if we should had this as a dependency of the new-tab meta issue and if the priority of this should still be P2?

Comment 4

[Shane Caraveo (:mixedpuppy)]

I'm not sure what the new-tab meta issue is. The new-tab selection in about:preferences would be unrelated to this. In any case, I think this is a low priority.

Comment 5

[davidrsmorris]

Hey, I'd like to bump this. This occurs when restarting the browser, too, and since I use an extension (tridactyl) to avoid using a mouse, this breaks my workflow, and sometimes I need to use the addons manager to re-enable the extension and restart the browser again.

Comment 6

[zouhairy]

The same(In reply to davidrsmorris from comment #5)

Hey, I'd like to bump this. This occurs when restarting the browser, too, and since I use an extension (tridactyl) to avoid using a mouse, this breaks my workflow, and sometimes I need to use the addons manager to re-enable the extension and restart the browser again.

Same here, it is quite infuriating.