1462285 - Remove const nsIChannel in XULBrowserWindow.onStateChange

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Dão Gottwald [:dao]]

The nsIChannel constant is used only once, and we should just use Ci.nsIChannel directly there:

https://searchfox.org/mozilla-central/rev/d4b9e50875ad7e5d20f2fee6a53418315f6dfcc0/browser/base/content/browser.js#4702,4735

Comment 1

[lucas05]

Hi, can I work on this?
It will be my first bug :)

Comment 2

[Dão Gottwald [:dao]]

(In reply to lucas05 from comment #1)
> Hi, can I work on this?
> It will be my first bug :)

Sure! Do you have the source code? Have you built Firefox yet? Let me know if you have questions.

Comment 3

[lucas05]

Hi Dão (nice name for a developer :)
I've built firefox, and I've made the change. What should i do for pushing my code?

Comment 4

[Dão Gottwald [:dao]]

You can attach the patch as a file to this bug: https://bugzilla.mozilla.org/attachment.cgi?bugid=1462285&action=enter

Or you can push to MozReview: https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview-user.html

Comment 5

[lucas05]

I want to attach the patch to the bug for now, cause the MozReview process is time consuming.
I've to commit my changes first right? Do I need to create a branch first?

Comment 6

[Dão Gottwald [:dao]]

You can use hg export after committing, or you could use hg diff without committing first.

Comment 7

[lucas05]

I've made the change in the browser.js file. But when I use hg diff or hg status, I have no output.
Do you know why?

Comment 8

[Dão Gottwald [:dao]]

(In reply to lucas05 from comment #7)
> I've made the change in the browser.js file. But when I use hg diff or hg
> status, I have no output.
> Do you know why?

Likely because you committed. What does hg export give you?

Comment 9

[lucas05]

It shows the change I've made :)

Comment 10

[Dão Gottwald [:dao]]

(In reply to lucas05 from comment #9)
> It shows the change I've made :)

You can save it to a patch file like this:

hg export > /path/to/patch.diff

Comment 11

[lucas05]

Attachment: patch.diff

Comment 12

[Dão Gottwald [:dao]]

Comment on attachment 8981777 [details] [diff] [review]
patch.diff

Looks good, thanks!

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efd5c0553e73
Remove const nsIChannel in XULBrowserWindow.onStateChange. r=dao

Comment 14

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/efd5c0553e73