1462308 - Disable devicelight, deviceproximity and userproximity events from stable

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P2)

Description

[Jonathan Kingston [:jkt] he/him]

In Bug 1359076 we disabled devicelight, deviceproximity and userproximity for Nightly and Early Beta.

Firefox started firing telemetry in late beta for these events along with the other related events Motion and Orientation.

The former that we plan to disable don't even seem to feature in this telemetry, I suspect due to the insignificant number of calls to this telemetry.

There haven't been any other reports calling for this feature so as planned in 62 we should disable these non standard events from stable.

Comment 1

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1462308 - Disable all Device Sensor events except orientation by default for stable.

Review commit: https://reviewboard.mozilla.org/r/244612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244612/

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8976492 [details]
Bug 1462308 - Disable all Device Sensor events except orientation by default for stable.

https://reviewboard.mozilla.org/r/244612/#review250816

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98a2883d9640
Disable all Device Sensor events except orientation by default for stable. r=bkelly

Comment 4

[Kohei Yoshino [:kohei]]

Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2018/ambient-light-and-proximity-sensor-apis-have-been-disabled/

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/98a2883d9640

Comment 6

[Chris Mills [:cmills]]

Ha, I didn't have much to do here because I did most of it in the previous related bug.

For this work, I've made sure the compat data is up-to-date:
https://github.com/mdn/browser-compat-data/pull/2505

And moved the release notes info to apply to Firefox 62:
https://developer.mozilla.org/en-US/Firefox/Releases/62#APIs_2

Does this look OK?

Comment 7

[Jonathan Kingston [:jkt] he/him]

This looks great thank you!