Closed Bug 1462330 Opened Last year Closed Last year
Update Debugger Frontend v55
Assignee: nobody → jlaster
Priority: -- → P3
feel free to wait until try is green
I need to do a fresh build to look at this. In the mean time, I can see that the README link wasn't updated; it still cites 53-54
haha had it locally, but failed to add to the patch
https://treeherder.mozilla.org/#/jobs?repo=try&revision=466f35c5e2be168067d00c6446a43098044bee7c I pushed a new patch with the stepping fix included. that should satisfy try...
I'm seeing the following upon import: ``` $ hg import https://bug1462330.bmoattachments.org/attachment.cgi?id=8976585 applying https://bug1462330.bmoattachments.org/attachment.cgi?id=8976585 patching file devtools/client/debugger/new/README.mozilla Hunk #1 FAILED at 0 1 out of 1 hunks FAILED -- saving rejects to file devtools/client/debugger/new/README.mozilla.rej file devtools/client/debugger/new/src/components/shared/Button/CloseButton.js already exists 1 out of 1 hunks FAILED -- saving rejects to file devtools/client/debugger/new/src/components/shared/Button/CloseButton.js.rej file devtools/client/debugger/new/src/components/shared/Button/PaneToggleButton.js already exists 1 out of 1 hunks FAILED -- saving rejects to file devtools/client/debugger/new/src/components/shared/Button/PaneToggleButton.js.rej file devtools/client/debugger/new/src/components/shared/Button/index.js already exists 1 out of 1 hunks FAILED -- saving rejects to file devtools/client/debugger/new/src/components/shared/Button/index.js.rej patching file devtools/client/shared/components/reps/reps.js Hunk #1 FAILED at 662 1 out of 4 hunks FAILED -- saving rejects to file devtools/client/shared/components/reps/reps.js.rej abort: patch failed to apply ``` Does that look familiar?
hmm, i think this could happen if you're not on top of 54... you can either apply on top of 54 or be in mozilla inbound, which has it.
Comment on attachment 8976585 [details] [diff] [review] 55-3.patch OK, cool, I figured out what I did wrong. Debugger loads and I saw a few of the changes that should be included. Nice!
Attachment #8976585 - Flags: review?(dwalsh) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cdddc03b03a9 Update Debugger Frontend v55. r=dwalsh
You need to log in before you can comment on or make changes to this bug.