Closed
Bug 1462398
Opened 6 years ago
Closed 6 years ago
Remove unused gcli commands
Categories
(DevTools Graveyard :: Graphic Commandline and Toolbar, enhancement, P2)
DevTools Graveyard
Graphic Commandline and Toolbar
Tracking
(firefox62 fixed)
RESOLVED
FIXED
Firefox 62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
A good followup to bug 1461970 is to remove all the commands that are not used by devtools codebase.
The commands that are still used are:
* paintflashing
* screenshot
* rulers
* measure
* eyedropper
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8976657 [details]
Bug 1462398 - Remove unused gcli commands.
https://reviewboard.mozilla.org/r/244748/#review251456
Thanks, this looks good! :)
What about the tool-associated command modules listed in definitions.js? Surely at least some of those can also be removed...?
Attachment #8976657 -
Flags: review?(jryans) → review+
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #2)
> Comment on attachment 8976657 [details]
> Bug 1462398 - Remove unused gcli commands.
>
> https://reviewboard.mozilla.org/r/244748/#review251456
>
> Thanks, this looks good! :)
>
> What about the tool-associated command modules listed in definitions.js?
> Surely at least some of those can also be removed...?
(Ah, I guess you filed a separate bug 1462399 for these!)
Assignee: nobody → jryans
Has Regression Range: --- → irrelevant
Has STR: --- → irrelevant
OS: Unspecified → All
Priority: -- → P2
Hardware: Unspecified → All
Assignee: jryans → poirot.alex
| Comment hidden (mozreview-request) |
|
||
Comment 5•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 22e7a5e666eae4d459810c3cbdb83d381b1d84b4 -d 64da6d6cc6d4: rebasing 465419:22e7a5e666ea "Bug 1462398 - Remove unused gcli commands. r=jryans" (tip)
local [dest] changed devtools/shared/gcli/commands/addon.js which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
unresolved conflicts (see hg resolve, then hg rebase --continue)
| Comment hidden (mozreview-request) |
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e9b1a091e83b
Remove unused gcli commands. r=jryans
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•6 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•