1462461 - Show the back button in the basic card page during on-boarding

Assignee

Description

•

6 years ago

Show the "Back" button in the basic card page during on-boarding to allow the user to go back to the address page to optionally edit the address that was entered by them in the previous step.

:prathiksha

Assignee

Updated

•

6 years ago

Assignee: nobody → prathikshaprasadsuman

Status: NEW → ASSIGNED

Matthew N. [:MattN]

Updated

•

6 years ago

Priority: -- → P1

Whiteboard: [webpayments]

Comment hidden (mozreview-request)

Review commit: https://reviewboard.mozilla.org/r/246994/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246994/

:prathiksha

Assignee

Updated

•

6 years ago

Blocks: 1427935

Matthew N. [:MattN]

Comment 2

•

6 years ago

mozreview-review

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

https://reviewboard.mozilla.org/r/246994/#review253740

::: browser/components/payments/res/containers/basic-card-form.js:121
(Diff revision 1)
>      this.saveButton.textContent = this.dataset.saveButtonLabel;
>      this.persistCheckbox.label = this.dataset.persistCheckboxLabel;
>      this.addressAddLink.textContent = this.dataset.addressAddLinkLabel;
>      this.addressEditLink.textContent = this.dataset.addressEditLinkLabel;
>  
> -    // The back button is temporarily hidden(See Bug 1462461).
> +    this.backButton.hidden = !page.previousId && page.onboardingWizard;

Isn't this going to be wrong when the dialog initially opens for someone who already has stored cards and addresses and thus goes initially to the summary page? We shouldn't have the back button on that summary page in this case, right?

Attachment #8980815 - Flags: review?(MattN+bmo)

:prathiksha

Assignee

Comment 3

•

6 years ago

(In reply to Matthew N. [:MattN] (PM if requests are blocking you) from comment #2)
> Comment on attachment 8980815 [details]
> Bug 1462461 - Show the back button in the basic card page during on-boarding.
> 
> https://reviewboard.mozilla.org/r/246994/#review253740
> 
> ::: browser/components/payments/res/containers/basic-card-form.js:121
> (Diff revision 1)
> >      this.saveButton.textContent = this.dataset.saveButtonLabel;
> >      this.persistCheckbox.label = this.dataset.persistCheckboxLabel;
> >      this.addressAddLink.textContent = this.dataset.addressAddLinkLabel;
> >      this.addressEditLink.textContent = this.dataset.addressEditLinkLabel;
> >  
> > -    // The back button is temporarily hidden(See Bug 1462461).
> > +    this.backButton.hidden = !page.previousId && page.onboardingWizard;
> 
> Isn't this going to be wrong when the dialog initially opens for someone who
> already has stored cards and addresses and thus goes initially to the
> summary page? We shouldn't have the back button on that summary page in this
> case, right?

page.onboardingWizard is null in that case. The back button will stay hidden.

Matthew N. [:MattN]

Comment 4

•

6 years ago

mozreview-review-reply

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

https://reviewboard.mozilla.org/r/246994/#review253740

> Isn't this going to be wrong when the dialog initially opens for someone who already has stored cards and addresses and thus goes initially to the summary page? We shouldn't have the back button on that summary page in this case, right?

Sorry, for some reason I thought this was payment-dialog.js. The logic still seems wrong to me… specifically the `&& page.onboardingWizard` part since we do sometimes want to show the back button during onboarding
e.g. add shipping address FTU => add basic card FTU

Matthew N. [:MattN]

Comment 5

•

6 years ago

mozreview-review-reply

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

https://reviewboard.mozilla.org/r/246994/#review253740

> Sorry, for some reason I thought this was payment-dialog.js. The logic still seems wrong to me… specifically the `&& page.onboardingWizard` part since we do sometimes want to show the back button during onboarding
> e.g. add shipping address FTU => add basic card FTU

OK, so after talking about it more with Prathiksha, the problem is that we don't set previousId when navigating to add/edit directly from the summary page (that seems inconsistent but I think it's how we can go back from add/edit billing => add/edit card => summary, using an array of previousIDs would be clearer and is a potential cleanup for later), we default to going back to the summary page in that case. I've asked her to add a comment here to explain that.

Comment hidden (mozreview-request)

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246994/diff/1-2/

Matthew N. [:MattN]

Comment 7

•

6 years ago

mozreview-review

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

https://reviewboard.mozilla.org/r/246994/#review254186

::: browser/components/payments/res/containers/address-form.js:236
(Diff revision 2)
>          page: {
>            id: "basic-card-page",
>            previousId: "address-page",
>            onboardingWizard: page.onboardingWizard,
>          },
> +        "address-page": addressPage,

I think line 249 already does this for you so this line can be removed:
```js
state.successStateChange[previousId] = Object.assign({}, currentState[previousId]);
```

::: browser/components/payments/res/containers/address-form.js:237
(Diff revision 2)
>            id: "basic-card-page",
>            previousId: "address-page",
>            onboardingWizard: page.onboardingWizard,
>          },
> +        "address-page": addressPage,
> +        preserveFieldValues: true,

I believe `preserveFieldValues` is supposed to be set on basic-card-page

::: browser/components/payments/res/containers/basic-card-form.js:222
(Diff revision 2)
> +        if (request.paymentOptions.requestShipping) {
> +          addressPage.guid = selectedShippingAddress;
> +        } else {
> +          addressPage.guid = basicCardPage.billingAddressGUID;
> +        }

Please add tests for the back button visiblity and that going back then clicking save updates the saved records appropriately and takes the user forward to the correct page.

Do we properly handle the case of empty storage where the user sees the address form, then the card form and then clicks back to make and edit and then saves again? They should end up on the card page again but I don't think we handled that so they may mistakenly end up on the summary page. I didn't test but please double-check this scenario.

::: browser/components/payments/res/containers/basic-card-form.js:223
(Diff revision 2)
> +          addressPage.guid = selectedShippingAddress;
> +        } else {
> +          addressPage.guid = basicCardPage.billingAddressGUID;

Please don't mutate the values that come from getState, you should make a clone with Object.assign({}, …); first.

Attachment #8980815 - Flags: review?(MattN+bmo)

Comment hidden (mozreview-request)

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246994/diff/2-3/

Matthew N. [:MattN]

Comment 9

•

6 years ago

mozreview-review

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

https://reviewboard.mozilla.org/r/246994/#review257802

::: browser/components/payments/res/containers/basic-card-form.js:232
(Diff revision 3)
> +            addressPageState = Object.assign(addressPage, {guid: selectedShippingAddress});
> +          } else {
> +            addressPageState = Object.assign(addressPage, {guid: basicCardPage.billingAddressGUID});

Object.assign assigns to the first argument so this is still mutating the addressPage from the state. You need to add an argument to the beginning which is `{}`:
```js
addressPageState = Object.assign({}, addressPage, {guid: selectedShippingAddress});
```

::: browser/components/payments/res/containers/basic-card-form.js:237
(Diff revision 3)
> +            addressPageState = Object.assign(addressPage, {guid: selectedShippingAddress});
> +          } else {
> +            addressPageState = Object.assign(addressPage, {guid: basicCardPage.billingAddressGUID});
> +          }
> +
> +          let basicCardPageState = Object.assign(basicCardPage, {preserveFieldValues: true});

Same problem here for `basicCardPage`. Please read the documentation on Object.assign on MDN

Attachment #8980815 - Flags: review?(MattN+bmo)

Comment hidden (mozreview-request)

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246994/diff/3-4/

Matthew N. [:MattN]

Comment 11

•

6 years ago

mozreview-review

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

https://reviewboard.mozilla.org/r/246994/#review258026

Thanks. I'm not sure if we have tests to ensure the back button isn't shown when it's not supposed to but they would be good.

Attachment #8980815 - Flags: review?(MattN+bmo) → review+

Pulsebot

Comment 12

•

6 years ago

Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d76b9bf7d97c
Show the back button in the basic card page during on-boarding. r=MattN

Dorel Luca [:dluca]

Comment 13

•

6 years ago

Backed out changeset d76b9bf7d97c (bug 1462461) for BC and TV failures on browser/components/payments/test/browser/browser_payments_onboarding_wizard.js

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=183880666&repo=autoland&lineNumber=5666

23:07:13     INFO - TEST-UNEXPECTED-FAIL | browser/components/payments/test/browser/browser_payments_onboarding_wizard.js | Cancel button is visible on the basic card page - false == true - 
[task 2018-06-19T23:07:13.808Z] 23:07:13     INFO - Stack trace:
[task 2018-06-19T23:07:13.809Z] 23:07:13     INFO - resource://testing-common/content-task.js line 59 > eval:null:68
[task 2018-06-19T23:07:13.810Z] 23:07:13     INFO - TEST-PASS | browser/components/payments/test/browser/browser_payments_onboarding_wizard.js | 4111111111111111 - "4111111111111111" == true - 
[task 2018-06-19T23:07:13.810Z] 23:07:13     INFO - Closing the payment dialog
[task 2018-06-19T23:07:14.202Z] 23:07:14     INFO - GECKO(1985) | --DOMWINDOW == 17 (0xe91cfe00) [pid = 2073] [serial = 56] [outer = (nil)] [url = about:blank]
[task 2018-06-19T23:07:14.204Z] 23:07:14     INFO - GECKO(1985) | --DOMWINDOW == 16 (0xe91cec00) [pid = 2073] [serial = 58] [outer = (nil)] [url = about:blank]
[task 2018-06-19T23:07:14.205Z] 23:07:14     INFO - GECKO(1985) | --DOMWINDOW == 15 (0xe7b7f000) [pid = 2073] [serial = 54] [outer = (nil)] [url = resource://payments/paymentRequest.xhtml]
[task 2018-06-19T23:07:14.207Z] 23:07:14     INFO - GECKO(1985) | --DOCSHELL 0xe2433400 == 3 [pid = 2073] [id = {84d8e88e-aa12-4f53-9cee-4635ff69cd43}]
[task 2018-06-19T23:07:14.208Z] 23:07:14     INFO - GECKO(1985) | --DOCSHELL 0xe2434800 == 2 [pid = 2073] [id = {c0f38f2c-57bd-457a-a54d-b035c4d23d14}]
[task 2018-06-19T23:07:14.406Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.408Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.410Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.411Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.413Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.416Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.417Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.433Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.435Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.437Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.440Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.442Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.445Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.445Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.462Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.463Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.464Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.465Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.467Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.470Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.471Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.473Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.474Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.475Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.476Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.477Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.478Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.480Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.588Z] 23:07:14     INFO - Leaving test bound test_back_button_on_basic_card_page_during_onboarding
[task 2018-06-19T23:07:14.726Z] 23:07:14     INFO - GECKO(1985) | --DOCSHELL 0xd69c4400 == 6 [pid = 1985] [id = {cd86bedd-0ef4-4321-ad74-26924b6b46d7}]
[task 2018-06-19T23:07:14.787Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.788Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.788Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.791Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.800Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.800Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.800Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.803Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.807Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.808Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.812Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.813Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.816Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.818Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.820Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.824Z] 23:07:14     INFO - GECKO(1985) | JavaScript error: chrome://payments/content/paymentDialogWrapper.js, line 338: NS_ERROR_NOT_INITIALIZED:
[task 2018-06-19T23:07:14.845Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.846Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.848Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.850Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.852Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.853Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.855Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.856Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.857Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.859Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.880Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.881Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.882Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.882Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.883Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.885Z] 23:07:14     INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED: " {file: "chrome://payments/content/paymentDialogWrapper.js" line: 338}]
[task 2018-06-19T23:07:14.894Z] 23:07:14     INFO - GECKO(1985) | MEMORY STAT | vsize 938MB | residentFast 270MB | heapAllocated 77MB
[task 2018-06-19T23:07:14.895Z] 23:07:14     INFO - TEST-OK | browser/components/payments/test/browser/browser_payments_onboarding_wizard.js | took 21919ms
[task 2018-06-19T23:07:14.914Z] 23:07:14     INFO - GECKO(1985) | ++DOCSHELL 0xe18bf800 == 5 [pid = 2134] [id = {98f6d87e-4a51-4a36-966b-c4718c71ea2f}]
[task 2018-06-19T23:07:14.919Z] 23:07:14     INFO - GECKO(1985) | ++DOMWINDOW == 23 (0xe90b04b0) [pid = 2134] [serial = 106] [outer = (nil)]
[task 2018-06-19T23:07:15.001Z] 23:07:15     INFO - checking window state
[task 2018-06-19T23:07:15.018Z] 23:07:15     INFO - GECKO(1985) | ++DOMWINDOW == 24 (0xe78c1c00) [pid = 2134] [serial = 107] [outer = 0xe90b04b0]
[task 2018-06-19T23:07:15.115Z] 23:07:15     INFO - TEST-START | browser/components/payments/test/browser/browser_profile_storage.js

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d76b9bf7d97cb19153b6cd8d7acfeb401ffe7a89&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Backout:
https://hg.mozilla.org/integration/autoland/rev/fb22e95175eac721f1c260bffc969bbdb26ab440

Flags: needinfo?(prathikshaprasadsuman)

Comment hidden (mozreview-request)

Comment on attachment 8980815 [details]
Bug 1462461 - Show the back button in the basic card page during on-boarding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246994/diff/4-5/

:prathiksha

Assignee

Updated

•

6 years ago

Flags: needinfo?(prathikshaprasadsuman)

Pulsebot

Comment 15

•

6 years ago

Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d5ec52381e06
Show the back button in the basic card page during on-boarding.r=MattN

Narcis Beleuzu [:NarcisB]

Comment 16

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/d5ec52381e06

Status: ASSIGNED → RESOLVED

Closed: 6 years ago

status-firefox62: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 62