Closed Bug 1462475 Opened 7 years ago Closed 7 years ago

Remove zones

Categories

(developer.mozilla.org Graveyard :: General, enhancement, P1)

Product:
developer.mozilla.org Graveyard
Component:
General
Platform:
All
Other
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jwhitlock, Assigned: rjohnson)

References

Details

(Keywords: in-triage, Whiteboard: [specification][type:change])

What feature should be changed? Please provide the URL of the feature if possible. ================================================================================== These are zones with URL roots: https://developer.mozilla.org/en-US/Firefox https://developer.mozilla.org/en-US/Add-ons They are at non-standard URLs for wiki docs, but they have standard paths: http://developer.mozilla.org/en-US/docs/Mozilla/Firefox https://developer.mozilla.org/en-US/docs/Mozilla/Add-Ons Most zones are for the purpose of promoting Mozilla-specific technologies, which was a former goal of Mozilla Developer Network. What problems would this solve? =============================== Zone URL roots cause several issues. Here are a few. Each request has to be examined to see if it affected by a zone URL root. This requires database access (to read zone records) or cache access (zone URL roots are cached). This causes performance and caching problems. Zone URL roots have to be special-cased in code and 3rd-party tools, such as Google Analytics and CloudFront, to categorize them as wiki document pages. This causes problems with metrics and dashboards, and often results in bugs that are not discovered until changes go to production. Some tools, like KumaScript, expect the "standard" path for a zoned document, while other code only works with the external URL. For most documents, the standard path is identical to the external path, so most changes are tested on these. The difference between the zoned and non-zoned URLs is a source of many bugs. Zone URL roots are poorly implemented across locales. Each locale requires its own zone record, linking the zone URL root with the translation in that locale. The zone record can't be created until the first translation is created. Many locales don't include the relevant zone, and many zone URL records are incorrect for seldom-used locales. This is a source of confusion for visitors. Who would use this? =================== Developers and MDN visitors What would users see? ===================== Developers would add redirects from current zoned URLs to the standard URLs and remove the request parsing that handles zoned URLs. Visitors would get a redirect from the zoned URL to the standard URL, What would users do? What would happen as a result? =================================================== Developers would see less bugs and faster time to feature completion. Lots of code that supports or works around zones can be removed and refactored. Django and functional tests can be updated and simplified. Visitors would see the same content as before, at different URLs/ Is there anything else we should know? ====================================== There is a related feature for custom styles for zones. This will be retained. Zone URLs are currently implemented with permanent redirects (301) from the standard URLs to the zoned URLs. These should be changed to temporary redirects for at least a few weeks before the redirects are changed from the zoned URLs to the standard URLs
Depends on: 1462479
Keywords: in-triage
Priority: -- → P2
Assignee: nobody → rjohnson
Status: NEW → ASSIGNED
Priority: P2 → P1
See Also: → 1465085
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/ee03db7da3e9bc811dd8e9a9f44f9181877a265c bug 1462475: fix tests/headless/test_cdn.py These tests were originally modified for the work of removing zones, but those modifications were made without realizing that some of the tests related to the caching of the redirects for former zone vanity URL's had to be asserted one way when behind a CDN and another when not. https://github.com/mozilla/kuma/commit/705339d6b92d1b788896b1727f7394567a4cd0be Merge pull request #4892 from escattone/headless-tests-1462475 bug 1462475: fix tests/headless/test_cdn.py
Commit pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/07ea9cc5130383421d9ece2062cc0d32bd026462 bug 1462475: Remove zones from boosting "boost" was 8.0 for zones, which is used in the SearchFilterBackend to boost zone root results. In the future, the boost function could be simplified.
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/1599c832a63af0f47a38ad69b9ddced79267adcd bug 1462475: Only look for redirects, not zones Use HEAD to detect if a document path is a zone, rather than GET to check if there is a zone style or redirect in the content as well. https://github.com/mozilla/kuma/commit/292df6af0da6ce130477433d1702694c9fe5fe59 bug 1462475: Rename DocumentRendered to Redirect Since the source now just checks for redirects and not the rendered page, rename DocumentRendered to DocumentRedirect. https://github.com/mozilla/kuma/commit/8e2b743ee2414ae9df559d00a8dccb0d21f8b697 bug 1462475: Rename DocumentRendered to Redirect Rename the files as well, hopefully in a way that makes it easier to follow the history of the file. https://github.com/mozilla/kuma/commit/7be7f6a58e6e7576d708fd037c08fedbf26edb2d bug 1462475: Drop zones from scraper Drop zone detection and creation from the MDN scraper. https://github.com/mozilla/kuma/commit/5b527e703ef90dfe35f3a20991203b90fb706145 bug 1462475: Remove zone paths in Document source Simplify the Document source to expect plain document paths and no zone data. https://github.com/mozilla/kuma/commit/3dc15e7276c7892b0aeaf789b82b24705f79d38a bug 1462475: Drop normalized_path The normalized_path was used to distinguish between the zone URL ('vanity URL') and the standard doc path. With Zones gone, there is no longer a difference. https://github.com/mozilla/kuma/commit/1f487e934b7c7fe88e6f5705d186b727c86ed1b3 Merge pull request #4920 from jwhitlock/scrape-zones-no-more-1462475 bug 1462475: Remove zone scraping
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/33a3ff792d3653d8f62e6ac66863106cdcf97032 bug 1462475: Remove zone move test Zones are deprecated, so this test is no longer required. https://github.com/mozilla/kuma/commit/e0bcf46f43e290c3f6991dc2c64b2ee9ca06a686 bug 1462475: Remove zone referencest from comments https://github.com/mozilla/kuma/commit/b2f05af6332598520d404b9deae80c7983fef3b6 bug 1462475: Drop db fixture from test The db fixture was needed by the zone middleware, which is gone. https://github.com/mozilla/kuma/commit/9bdc876070a3b3cb8009f8e6654508cb0ad35be7 bug 1462475: Don't preload zone_subnav_local_html This field is unused with zones disabled. https://github.com/mozilla/kuma/commit/216fa0a5b940b00a787b9055dbb1ef2c42e7b461 Merge pull request #4921 from jwhitlock/zones-are-dying-1462475 bug 1462475: Remove some more references to zones
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/ca4328f7a083296540a96da861ea466278d7f192 bug 1462475: remove models/fields related to zones * Delete DocumentZone model * Remove the "zone_subnav_local_html" field from Document model https://github.com/mozilla/kuma/commit/b6eedaccf2bd88c4c1e6616fe9a2cb3dd2e6897b Merge pull request #4923 from escattone/remove-zone-db-references-1462475 bug 1462475: remove models/fields related to zones
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/5dd641cfe8ecfaa26677b0478be464c483348c68 bug 1462475: Drop zone table in anon script Don't clone the table when anonymizing, and drop it if present. https://github.com/mozilla/kuma/commit/edbb59c23398f1c28218f4d17e72fccc643402df Merge pull request #4927 from jwhitlock/anon-zones-1462475 bug 1462475: Drop zone table in anon script
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/5808bb6c523d02dba586b1f54db740012fbbb61e bug 1462475: add db migration to cleanup after zones https://github.com/mozilla/kuma/commit/c504d129cdca06ae5d6d38446df0b79cf7968136 Merge pull request #4924 from escattone/zone-db-migration-1462475 bug 1462475: add db migration to cleanup after zones
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
The scope expanded to removing zone styles as well as URL roots for zones.
Summary: Remove URL roots for zones → Remove zones
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/51301d4b943f5eede2ae552ec2ebcc366706fb36 bug 1462475: Treat zone vanity URLs as errors If a zone vanity URL, like /en-US/Firefox/Releases/22, is requested, then treat as an errored Document, rather than raise an exception and halt scraping. https://github.com/mozilla/kuma/commit/d8e493770750a347cfc6090d881750ae15897759 Merge pull request #4964 from jwhitlock/scrape-links-1462475 bug 1462475: Improve ./manage.py scrape_links
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.