1462500 - Support (and test) temporary installs with .zip extensions (for now)

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Kris Maglione [:kmag]]

I don't particularly like this, but since we have special code in about:debugging to support it, removing support should probably be a product decision.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1462500: Improve our detection of XPI vs. directory installs.

This adds a helper so that we consistently detect install type based on
extension the same way.

In the process, it also simplifies some of the code that tries to detect
modification times for unpacked directories, so that it only checks the
directory mtime. We don't support signatures for unpacked directories anymore,
so this has no purpose outside of developer builds with signing disabled.
Those developers can move to touching the install directory's mtime rather than
the manifest file's.

Review commit: https://reviewboard.mozilla.org/r/244842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244842/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8976746 [details]
Bug 1462500: Improve our detection of XPI vs. directory installs.

https://reviewboard.mozilla.org/r/244842/#review251568

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cef00f3131bec5de42ab725cceb7821eef50b0a5
Bug 1462500: Improve our detection of XPI vs. directory installs. r=aswan

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cef00f3131be

Comment 7

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Using the latest Nightly(20180604100129) on Windows while trying to install a zip archived extension I get: "There was an error during installation: File E:\Temp\restricted folder view\video_downloadhelper-7.3.0-an+fx.zip does not contain a valid manifest"