1462571 - Crash in mozalloc_abort | abort | libdbus-1.so.3.19.4@0x36203 | Firefox crashes on start up, suspect non-Latin profile name

Status: RESOLVED FIXED

(Core Graveyard :: X-remote, defect)

Description

[Lachezar Dobrev]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180517114003

Steps to reproduce:

Xubuntu 18.04, Firefox 60.0 and 60.0.1
1. Create profile with Cyrillic characters in the name, ex: Кирилица
2. Start Firefox with that profile: firefox -P "Кирилица"
+ same error if the default profile has non-Latin name and run default: firefox


Actual results:

Firefox crashes, shows "Report Bug" window.
Running in console shows error message:

dbus[7313]: arguments to dbus_bus_request_name() were incorrect, assertion "_dbus_check_is_valid_bus_name (name)" failed in file ../../../dbus/dbus-bus.c line 1122.
This is normally a bug in some application using the D-Bus library.

  D-Bus not built with -rdynamic so unable to print a backtrace
Redirecting call to abort() to mozalloc_abort

ExceptionHandler::GenerateDump cloned child 7368
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
ExceptionHandler::WaitForContinueSignal waiting for continue signal...



Expected results:

Firefox should start normally.

Comment 1

[Lachezar Dobrev]

Current work-around:
firefox --profile /path/to/profile/directory

Comment 2

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
20180516032328

(In reply to Lachezar Dobrev from comment #0)
> 2. Start Firefox with that profile: firefox -P "Кирилица"

Works for me. Setting platform to Linux.

> Firefox crashes, shows "Report Bug" window.

Do you mean the crash reporter? If so, please enter about:crashes into the address bar and paste the relevant report ID in a comment here. Otherwise, please try a build from mozilla.org, report the crash from it, then post the report ID here.
https://developer.mozilla.org/docs/Mozilla/How_to_get_a_stacktrace_for_a_bug_report

Comment 3

[Lachezar Dobrev]

Is this it:
https://crash-stats.mozilla.com/report/index/dfc68faa-8c45-4579-93b2-22de50180518

OS = Linux, yes
I do not thing DBus is available on other platforms, right?

Comment 4

[Gingerbread Man]

Thank you.

:stransky this looks like your bailiwick. Please have a look if you can.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Sure.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1462571 - Check dbus name by dbus_validate_bus_name() before use,

Review commit: https://reviewboard.mozilla.org/r/245084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245084/

Comment 7

[Jan Horak [:jhorak]]

Comment on attachment 8976922 [details]
Bug 1462571 - Check dbus name by dbus_validate_bus_name() before use,

https://reviewboard.mozilla.org/r/245084/#review251038

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09a2a68cfc77
Check dbus name by dbus_validate_bus_name() before use, r=jhorak

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/09a2a68cfc77

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Please request Beta and ESR60 approval on this patch when you're comfortable doing so.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8976922 [details]
Bug 1462571 - Check dbus name by dbus_validate_bus_name() before use,

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: Firefox crashes at start up when Cyrillic characters is used at profile name.
Fix Landed on Version: 62.0
Risk to taking this patch (and alternatives if risky): low, baked on nightly and it's one time check at browser start up.
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8976922 [details]
Bug 1462571 - Check dbus name by dbus_validate_bus_name() before use,

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1360566
[User impact if declined]: Firefox crashes at start up when Cyrillic characters is used at profile name.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: Low risk as it's one time check at browser start up.
[String changes made/needed]: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8976922 [details]
Bug 1462571 - Check dbus name by dbus_validate_bus_name() before use,

Fix for possible startup crash on some Linux systems. Approved for 61.0b9 and ESR 60.1.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a46bd94230c7

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/977eb5c43f72

Comment 16

[Lachezar Dobrev]

I tried Beta and Nightly channel releases:

Pass on 62.0a1 (2018-05-27) (64-bit).

Fail on 61.0b8 (64-bit):

https://crash-stats.mozilla.com/report/index/10f93217-45cc-4e25-85d0-29db70180528

dbus[18483]: arguments to dbus_bus_request_name() were incorrect, assertion "_dbus_check_is_valid_bus_name (name)" failed in file ../../../dbus/dbus-bus.c line 1122.
This is normally a bug in some application using the D-Bus library.

  D-Bus not built with -rdynamic so unable to print a backtrace
Redirecting call to abort() to mozalloc_abort

ExceptionHandler::GenerateDump cloned child 18570
ExceptionHandler::SendContinueSignalToChild sent continue signal to child
ExceptionHandler::WaitForContinueSignal waiting for continue signal...

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Per comment 13, the fix will be in b9, not b8.

Comment 18

[Arrigo Marchiori]

FYI, this spawned bug #1472611