1462580 - Don't exit fullscreen when creating new not active tab

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[juraj.masiar]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180514150347

Steps to reproduce:

1) open debugging console of any add-on with `tabs` permission
2) execute this code:
`setTimeout(() => browser.tabs.create({url: 'https://developer.mozilla.org/', active: false}), 9000);`
3) open any YouTube video on fullscreen (you have 9 seconds)


Actual results:

After 9 seconds the fullscreen will exit - even when active tab has not changed.


Expected results:

Fullscreen should stay active when non-active tab has been created.

Why is this important? My add-on is using tab-hiding feature to make some work "in background". However creating new tab and hiding it will trigger fullscreen exit.

Comment 1

[Kris Maglione [:kmag]]

https://searchfox.org/mozilla-central/rev/da499aac682d0bbda5829327b60a865cbc491611/browser/base/content/browser-fullScreenAndPointerLock.js#463

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1462580 - Don't exit DOM fullscreen mode when opening or closing background tabs.

Review commit: https://reviewboard.mozilla.org/r/246036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246036/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8979855 [details]
Bug 1462580 - Don't exit DOM fullscreen mode when opening or closing background tabs.

https://reviewboard.mozilla.org/r/246036/#review252240

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30dbf7c51250
Don't exit DOM fullscreen mode when opening or closing background tabs. r=jaws

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/30dbf7c51250

Comment 6

[Cristian Fogel [:cfogel]]

(In reply to juraj.masiar from comment #0)
> 1) open debugging console of any add-on with `tabs` permission

Could you post an example of such an addon?
Thank you

Comment 7

[juraj.masiar]

You can try my GroupSpeedDial:
https://addons.mozilla.org/en-US/firefox/addon/groupspeeddial/

Comment 8

[Cristian Fogel [:cfogel]]

Thank you for the link.

Managed to reproduce the issue, following the steps in comment 0, and with the addon posted above on Firefox 62.0a1 (build 
20180510220127)

Have checked with 62.0b7 on macOS 10.13.4, Win 10x64, Ubuntu 16.04LTS and can confirm the issue has been fixed.