1462625 - buildbot jobs don't load summaries anymore

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[[e-mail] (:bhearsum)]

There's errors like 'TypeError: "({title:"Buildername"})' in the Browser Console.

Comment 1

[Ed Morley [:emorley]]

Regression from:
https://github.com/mozilla/treeherder/commit/be3c6e8bc9caf31584196fec40d14d243adb4a39

Array.prototype.findIndex() only supports being passed a predicate function only:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex

...whereas _.findIndex() supported the _.matches() style shorthand:
https://lodash.com/docs#findIndex

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3561

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f8f260c165ad336bed4fcfc3325e572c5ab72c32
Bug 1462625 - Fix TypeError when selecting buildbot jobs (#3561)

This was changed from `_.findIndex()` to `Array.prototype.findIndex()`
in #3537, however was using the former's `_.matches()` shorthand
style, which isn't supported by the ES6 equivalent.

https://lodash.com/docs#findIndex
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/findIndex

Comment 4

[Ed Morley [:emorley]]

This was deployed to production earlier.