Closed
Bug 1462662
Opened 7 years ago
Closed 6 years ago
Wipe the container for privacy.usercontext.about_newtab_segregation.enabled on shutdown
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
People
(Reporter: tjr, Assigned: baku)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 2 obsolete files)
7.38 KB,
patch
|
johannh
:
review+
|
Details | Diff | Splinter Review |
7.52 KB,
patch
|
RyanVM
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1457929 +++
As discussed in Bug 1457929 - we should clear out the container used by privacy.usercontext.about_newtab_segregation.enabled (which I believe is '5') so we don't make a persistent container that tracks the user through thumbnails.
:baku proposed doing it on shutdown (and startup in case of crash.)
Updated•7 years ago
|
Component: Bookmarks & History → Activity Streams: Newtab
Assignee | ||
Comment 1•7 years ago
|
||
This should be enough to cleanup the container number 5.
Assignee: nobody → amarchesini
Attachment #8979530 -
Flags: review?(jhofmann)
Comment 2•7 years ago
|
||
Comment on attachment 8979530 [details] [diff] [review]
container_5.patch
Review of attachment 8979530 [details] [diff] [review]:
-----------------------------------------------------------------
As mentioned on IRC, I think we'll have to find a different solution for this because pending sanitization is currently only set when the user has chosen to clear data on shutdown.
Attachment #8979530 -
Flags: review?(jhofmann) → review-
Assignee | ||
Comment 3•6 years ago
|
||
Attachment #8979530 -
Attachment is obsolete: true
Attachment #8981372 -
Flags: review?(jhofmann)
Assignee | ||
Comment 4•6 years ago
|
||
Attachment #8981372 -
Attachment is obsolete: true
Attachment #8981372 -
Flags: review?(jhofmann)
Attachment #8981387 -
Flags: review?(jhofmann)
Comment 5•6 years ago
|
||
Comment on attachment 8981387 [details] [diff] [review]
container_5.patch
Review of attachment 8981387 [details] [diff] [review]:
-----------------------------------------------------------------
This should work, thanks!
::: browser/modules/Sanitizer.jsm
@@ +59,5 @@
> */
> PREF_TIMESPAN: "privacy.sanitize.timeSpan",
>
> /**
> + * Pref to newTab segretation
spelling: segregation
You might also want to explain why that pref is here.
::: browser/modules/test/unit/test_Sanitizer_interrupted.js
@@ +11,5 @@
>
> add_task(async function() {
> ChromeUtils.import("resource:///modules/Sanitizer.jsm");
> +
> + Services.prefs.setBoolPref(Sanitizer.PREF_NEWTAB_SEGREGATION, false);
You need to clear this pref as well.
Attachment #8981387 -
Flags: review?(jhofmann) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62ed84f80e37
Wipe the container for privacy.usercontext.about_newtab_segregation.enabled on shutdown, r=johannh
Comment 7•6 years ago
|
||
Backed out changeset for mochitest browser chrome failures on browser_startup.js
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&tochange=385a43483f1e06dc862c1aa159f41d0f3fac3fb7&fromchange=62ed84f80e377811d9e371b94c06243626aec230&filter-searchStr=browser%20chrome&filter-failure_classification_id=2&selectedJob=180742579
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=180742579&repo=mozilla-inbound&lineNumber=1994
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/385a43483f1e06dc862c1aa159f41d0f3fac3fb7
Flags: needinfo?(amarchesini)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e62b8b3202a
Wipe the container for privacy.usercontext.about_newtab_segregation.enabled on shutdown, r=johannh
Comment 9•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Reporter | ||
Comment 10•6 years ago
|
||
Comment on attachment 8981387 [details] [diff] [review]
container_5.patch
[Feature/Bug causing the regression]: If Bug 1457929 is taken in beta, we should take this patch too.
[User impact if declined]: None; unless Bug 1457929 is taken in which case we'll have a weird (but not dangerous) situation for a release.
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: Only needed if we take Bug 1457929
[Is the change risky?]: Not very.
[Why is the change risky/not risky?]: It adds a background sanitization. I supposed it's possible this could cause problems, but we use existing history-removal APIs for this.
Attachment #8981387 -
Flags: approval-mozilla-beta?
Comment 11•6 years ago
|
||
Comment on attachment 8981387 [details] [diff] [review]
container_5.patch
Patch to harden the privacy of the privacy.usercontext.about_newtab_segregation.enabled preference. Approved for 61.0b11.
Attachment #8981387 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Assignee | ||
Comment 13•6 years ago
|
||
Flags: needinfo?(amarchesini)
Updated•6 years ago
|
Attachment #8982344 -
Attachment is patch: true
Attachment #8982344 -
Flags: approval-mozilla-beta+
Updated•6 years ago
|
Attachment #8981387 -
Flags: approval-mozilla-beta+
Comment 14•6 years ago
|
||
bugherder uplift |
status-firefox61:
--- → fixed
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
Updated•9 months ago
|
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•