1462678 - submitCrash(Intent intent) : Dead local store on crashId

Status: RESOLVED FIXED

(GeckoView :: General, defect, P3)

Description

[Sylvestre Ledru [:Sylvestre]]

This line is very likely useless:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashReporterService.java#150

Comment 1

[Arshad Kazmi [:arshadkazmi42]]

Can I take this up? Is it available for grab?

Comment 2

[Chris Peterson [:cpeterson]]

Hi Arshad, thanks for your interest! Have you built Firefox for Android before? The first step for fixing this bug is download and build the code. Here are instructions:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build

Comment 3

[Arshad Kazmi [:arshadkazmi42]]

Hey Chris,
I have one doubt. 
So I already have a Desktop build running in my laptop. Is it possible to have android build also with the same folder in which my desktop build is running?

Comment 4

[Arshad Kazmi [:arshadkazmi42]]

done with the android artifact setup.
Any specific things I need to follow? or just have to open android code in android studio and make changes?

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Correct :)

Also, as the code changed, the correct line is now:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/CrashReporterService.java#200
                final String crashId = passedMinidumpName.substring(0, passedMinidumpName.length() - 4);

Comment 6

[Arshad Kazmi [:arshadkazmi42]]

I made the changes, but getting some issues during build in android studio.
Is there some docs to generate apk using 'mach' or anyother tool for that, to verify my fix?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

you should fix the build issues first.

Then, see https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build#Deploy_Firefox_to_an_Android_device :)

Comment 8

[Arshad Kazmi [:arshadkazmi42]]

I am getting this error

Building with Gradle is only supported for Fennec, i.e., MOZ_BUILD_APP == 'mobile/android'.

Am I missing something from setup docs?

Comment 9

[Sylvestre Ledru [:Sylvestre]]

yes, please read the doc that Chris shared with you.

Comment 10

[Arshad Kazmi [:arshadkazmi42]]

Attachment: Bug 1462678 - Remove an unused call in the android CrashReporterService

Comment 11

[Arshad Kazmi [:arshadkazmi42]]

finally done with the build and completed the fix.
Pushed the code to phabricator for review

Whom should I add as reviewer?

Comment 12

[Sylvestre Ledru [:Sylvestre]]

You will find the information here :)
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_Get_your_code_reviewed

(I am not lazy, I am giving you pointers for you to understand how to do it :)

Comment 13

[Arshad Kazmi [:arshadkazmi42]]

So I found two reviewers from previous commits to the same file.

:jchen && :snorp	

Go to add them & you :sylvestre (as you are assigned mentor)

as reviewers for my code push

Comment 14

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9004075 [details]
Bug 1462678 - Remove an unused call in the android CrashReporterService

Jim Chen [:jchen] [:darchons] has approved the revision.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48ca12e943f5
Removed unused code from Gecko r=jchen

Comment 16

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/48ca12e943f5