1462738 - Bookmarks toolbar user-created button shows (Empty) instead of tagged bookmarks

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[[e-mail]]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180516032328

Steps to reproduce:

Several years ago I added used two specific tags to tag bookmarks that I frequently access.  Then I created two buttons for Bookmarks Toolbar (don't remember how) and the tagged bookmarks showed up under the new buttons on the Bookmarks Toolbar. As of this morning (after Firefox updated to version 60.0.1) these two custom buttons now show (Empty) instead of the 20+ bookmarks that used to show up. When I show all bookmarks they are still tagged as before.


Actual results:

My custom buttons on Bookmarks Toolbar now show (Empty) instead of the tagged bookmarks I  usually see.


Expected results:

Tagged bookmarks should have showed up under the custom buttons.

Comment 1

[Gingerbread Man]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
20180517141400

(In reply to [e-mail] from comment #0)
> Then I created two buttons for Bookmarks Toolbar (don't remember how)

Can't reproduce the issue without steps to reproduce the issue.

The following works for me:

1. Open the Library (Ctrl+Shift+B).
2. On the left, select the Bookmarks Toolbar folder.
3. Click the Organize button, then New Bookmark.
4. Name the bookmark whatever you wish. Enter the following in the Location box, replacing the word dupe with whatever tag you actually want to search for.
place:queryType=1&tag=dupe
5. Click the Add button to finish, then exit and restart Firefox.

https://developer.mozilla.org/docs/Mozilla/Tech/Places/Places_query_URIs

Comment 2

[[e-mail]]

Gingerbread Man:

Your suggestion works for setting up new buttons that function exactly like my "old" buttons which I have now replaced.

Thank you.

However, doesn't explain why my "old" buttons became useless after Firefox updated to version 60.0.1

Comment 3

[Gingerbread Man]

Thank you for the update.

If you still have the old bookmarks, you could set up a separate profile [1] with them and try the old version of Firefox [2] where they still worked. If they still work there, you could then proceed to test that profile with mozregression [3] to find out which bug made them stop working.

Otherwise, I doubt anyone can tell you what went wrong, without even knowing the query URL for the bookmarks in question. I'll leave this open in case someone wants to investigate further, but it'll probably be closed as Worksforme.

[1] https://support.mozilla.com/kb/profile-manager-create-and-remove-firefox-profiles
[2] https://archive.mozilla.org/pub/firefox/releases/
[3] https://mozilla.github.io/mozregression/quickstart.html

Comment 4

[Mark Banner (:standard8)]

Hi, you might still be able to help us if you have some old bookmark backups.

If you go to Help -> Troubleshooting Information, and look in the first section for "Profile folder". There should be a button to let you open it. Within that folder, there should be another one call "bookmarkbackups" which will probably contain about 15 files.

If there are one or two there from before you upgraded, would you mind sending them to me so that I can analyse it and see what may have gone wrong? The best way to do it would be to upload to https://send.firefox.com/ and get a link and send that to me via my email (standard8 at mozilla dot com).

I'll only use it for this analysis.

The alternative is if you can unpack them and search them for "place:" - it'll look a bit like a url, e.g. "place:folder=123". There may be a few of them, I'd need to see what they all are.

Comment 5

[[e-mail]]

Mark:

OK, I uploaded file bookmarks-2018-04-28_2269_PsLYzSdaq75pIfrZmaBs6w==.jsonlz4 which was definitely before the update.

Let me know if you need another file.

Comment 6

[Mark Banner (:standard8)]

Did you email the upload link to me, I don't see it in my inbox, nor in my spam?

Comment 7

[Mark Banner (:standard8)]

Thank you for that, the query here is of the form:

place:terms=foo&folder=BOOKMARKS_MENU&folder=TOOLBAR&folder=UNFILED_BOOKMARKS&expandQueries=0&queryType=1

where foo is matching one of the tags.

It doesn't seem to work in the toolbar from 60 onwards, but it does work in the Library window. I'm not quite sure why yet.

Comment 8

[Mark Banner (:standard8)]

I checked with mozregression, and it is bug 1428342 that caused this.

11:32.60 INFO: No more inbound revisions, bisection finished.
11:32.60 INFO: Last good revision: e9d182c93bc1702c72dd4cac369044da2e30a280
11:32.60 INFO: First bad revision: cba9a29be139a663869a2c26557fd527a6981407
11:32.60 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e9d182c93bc1702c72dd4cac369044da2e30a280&tochange=cba9a29be139a663869a2c26557fd527a6981407

Comment 9

[Mark Banner (:standard8)]

If I remove expandQueries=0 from the query, then the query works fine.