1462741 - Function.prototype.toString() is not displayed as a native function

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[André Bargull [:anba]]

https://github.com/tc39/test262/blob/master/test/built-ins/Function/prototype/toString/well-known-intrinsic-object-functions.js expects that |Function.prototype.toString()| returns the string representation of a native function.


Test case:
---
print(Function.prototype.toString());
---

Expected: "function () {\n    [native code]\n}"
Actual: "function () {\n}"

Comment 1

[Tom S [:evilpie]]

I wonder if this means that we can make Function.prototype a real native function, instead of an interpreted function: https://searchfox.org/mozilla-central/rev/3fdc51e66c9487b39220ad58dcee275fca070ccd/js/src/vm/JSFunction.cpp#857

Comment 2

[Tom S [:evilpie]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f81db683e726f75a7af149cf6f982e24c418e3cb

Comment 3

[Tom S [:evilpie]]

Interesting behaviour change from this: Function.prototype.{arguments, caller} now throw, because it's a native (built-in) function. Chrome also behaves like this, so it's probably web-compatible.

Comment 4

[Tom S [:evilpie]]

Attachment: Make Function.prototype a native function

Comment 5

[Tom S [:evilpie]]

Attachment: Test changes

Various debugger tests were observing Function.prototype.

Comment 6

[Tom S [:evilpie]]

Attachment: Bug 1462741 - Make Function.prototype a native function. r?jorendorff

Comment 7

[Tom S [:evilpie]]

Attachment: Bug 1462741 - Update tests. r?jorendorff

Depends on D14704

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d987ede1c79
Make Function.prototype a native function. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/f23ff3309649
Update tests. r=jorendorff

Comment 9

[Tom S [:evilpie]]

I still need to update jstests.list

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/7d987ede1c79
https://hg.mozilla.org/mozilla-central/rev/f23ff3309649

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/faac12c6cb61
Enable test262 test. r=me

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/faac12c6cb61