1462860 - Firefox uses system colors as default and it makes things hard to read

Status: UNCONFIRMED

(Core :: Layout, defect, P3)

Description

[brooks.johnson88]

Attachment: Screenshot from 2018-05-18 21-16-19.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180327185825

Steps to reproduce:

I'm running Linux Mint with the [adapta nokoto theme](https://github.com/adapta-project/adapta-gtk-theme) and I'm using Firefox 59.  

I also have the "Use system colors" option unchecked in the Colors popup in about:preferences


Actual results:

On web sites that don't define a text color or a background color, the text in the control or the background of the control will default to the system color which makes things very hard to read.


Expected results:

Firefox should use its own colors as fallback defaults defined in about:config.

Note: In the attached file, the "Country" field is actually filled out - it says "United States"

Comment 1

[brooks.johnson88]

Attachment: System default font color used in Version text

Comment 2

[Timea Cernea [:tbabos][inactive]]

Hi brooks.johnson88,

I didn’t manage to reproduce the issue on Ubuntu 16.04 x64 with the steps provided in the report.
Can you please retest the issue on latest Nightly using a new clean Firefox profile (https://goo.gl/AWo6h8) as well as safe mode (https://goo.gl/AR5o9d) to eliminate custom settings as a possible cause and report back the result?

Thank you.

Comment 3

[brooks.johnson88]

(In reply to Timea Babos from comment #2)
> Hi brooks.johnson88,
> 
> I didn’t manage to reproduce the issue on Ubuntu 16.04 x64 with the steps
> provided in the report.
> Can you please retest the issue on latest Nightly using a new clean Firefox
> profile (https://goo.gl/AWo6h8) as well as safe mode (https://goo.gl/AR5o9d)
> to eliminate custom settings as a possible cause and report back the result?
> 
> Thank you.

Hi Timea,

I retried following your instructions and got the same results.  Also, I want to be clear that you won't see the issues I reported on every website - it looks like it depends on the site's CSS and if properties like background-color are set.  I'll take some more screenshots that show the issue better.

Comment 4

[brooks.johnson88]

Attachment: background is set by site CSS

Comment 5

[Timea Cernea [:tbabos][inactive]]

Thank you for the reply!
I will set a component in order to involve the development team in a proper review of the issue.

Comment 6

[brooks.johnson88]

Attachment: background *not* set by site CSS

Comment 7

[brooks.johnson88]

Comment on attachment 8980285 [details]
background *not* set by site CSS

Here you can see how most of the text controls have backgrounds that default to #29353b, which is the color set by the system theme Adapta Nokoto (https://github.com/adapta-project/adapta-gtk-theme/blob/ee1dfe43ec784e41c166423242f6a86ba0465c16/gtk/sass/common/_colors.scss#L101), not the firefox default which is shown in the about:config.

The email field is shown as expected only because I manually set the background property in the CSS.