1462873 - Bug 1393119 undid bug 1257888

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1462873 - Link chromium_atomics to webrtc tests.

This redoes bug 1257888 which bug 1393119 undid.

Review commit: https://reviewboard.mozilla.org/r/245286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245286/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8979014 [details]
Bug 1462873 - Link chromium_atomics to webrtc tests.

https://reviewboard.mozilla.org/r/245286/#review251230

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/20cf35432bfa
Link chromium_atomics to webrtc tests. r=froydnj

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8979014 [details]
Bug 1462873 - Link chromium_atomics to webrtc tests.

[Approval Request Comment]
User impact if declined: Build failure on powerpc* (tier-3) platforms
Fix Landed on Version: 62
Risk to taking this patch (and alternatives if risky): The patch affects all platforms in that it makes an additional library be linked to the binary, but:
- it's a test-only binary
- this was happening before a regression in the build system in 60.
So overall, risk is very low to inexistent.
String or UUID changes made by this patch: N/A

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/20cf35432bfa

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8979014 [details]
Bug 1462873 - Link chromium_atomics to webrtc tests.

Approved for 61.0b7 and ESR 60.1.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/dd95eb07aa8c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/26f17ded038f