1462948 - Can’t load about:addons favicon in addon

Status: RESOLVED DUPLICATE of bug 1315616

(Toolkit :: Add-ons Manager, defect)

Description

[ariasuni]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180518105509

Steps to reproduce:

I retrieved the favicon URL of the about:addons page — no other page linked in about:about had this problem — with the WebExtensions tab API, and used it as a background-image.


Actual results:

Favicon din’t load, and I got that message in the debugger:

Security Error: Content at moz-extension://8ea38fac-970c-4e22-9316-0121f83bd043/sidebar/tabcenter.html may not load or link to chrome://mozapps/skin/extensions/extensionGeneric-16.svg.


Expected results:

The favicon should have loaded, like chrome://browser/skin/settings.svg, chrome://branding/content/icon32.png or chrome://global/skin/icons/warning-16.png.

Comment 1

[ovidiu boca[:Ovidiu]]

Hi ariasuni,

Can you please try to reproduce this on the latest FF Nightly? Please download Firefox Nightly from here: https://nightly.mozilla.org/

Comment 2

[ariasuni]

Same problem with Nightly (same icon URL, still not loading). You can reproduce it easily in Tab Center Redux: preferences favicon loads but this one doesn’t.

Also, the error message is triggered there I think: https://github.com/eoger/tabcenter-redux/blob/ec6c366ac27f3fe18459590f740ae3c29c7fa6f1/src/sidebar/tab.js#L173

One important thing I forgot is that sometimes, but rarely, the icon does load, and after refreshing the page it doesn’t load again.

Comment 3

[Shane Caraveo (:mixedpuppy)]

access to chrome urls will not be provided.  Getting access to some favicons is in bug 1315616

Comment 4

[ariasuni]

That doesn’t look a duplicate. Why do I have to keep maintaining additional code when I can access without error chrome://browser/skin/privatebrowsing/favicon.svg, chrome://browser/skin/developer.svg or chrome://browser/skin/settings.svg.?

I was checking if the URL was chrome://mozapps/skin/extensions/extensionGeneric-16.svg to replace it with my own favicon, but now the URL has been changed to chrome://mozapps/skin/extensions/extension.svg, I’m lucky to have catched this on Firefox Developer Edition before it arrived on Release… This may break other extensions as well.

It seems extensions can use all favicons in chrome://browser/skin as opposed to ones in chrome://mozapps/skin/extensions/, is it possible to change the path of this page’s favicon so that everything is coherent and it fixes my use case and things just work and don’t fail in an unexpected way in some cases for extensions developer?

If this is OK, I’m willing to write the patch.

Comment 5

[ariasuni]

I checked all the about: pages, and there is also chrome://devtools/skin/images/profiler-stopwatch.svg from about:profiling that I can’t use, so I need to add another exception to my extension and this is not ideal.