1462993 - PerformanceObserver.observe should not throw if the list is empty

Status: RESOLVED DUPLICATE of bug 1403027

(Core :: DOM: Core & HTML, defect, P2)

Description

[Andrea Marchesini [:baku]]

https://w3c.github.io/performance-timeline/#dom-performanceobserver-observe
"If the resulting entry types sequence is an empty sequence, abort these steps."

Comment 1

[Andrea Marchesini [:baku]]

Attachment: performance7.patch

Comment 2

[Valentin Gosu [:valentin]]

Comment on attachment 8979110 [details] [diff] [review]
performance7.patch

Review of attachment 8979110 [details] [diff] [review]:
-----------------------------------------------------------------

Make sure to use add the reasoning and link to the commit message description.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/591cbed375cd
PerformanceObserver.observe should not throw if the list is empty, r=valentin

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5486694a9bc9
Fixing a failure related to PerformanceObserver in longtask-tojson.html, r=me

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53a1f773dfd0
Fixing a failure related to PerformanceObserver in longtask-tojson.html, r=me CLOSED TREE

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d7f3f32600
Backed out 3 changesets wpt failures on nav2_test_attributes_exist.html. CLOSED TREE

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for wpt failures on nav2_test_attributes_exist.html.

This is the last push that tried to fix the wpt issues but it still failed: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=wpt&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&fromchange=591cbed375cd5999335298c8f549dca2be7c14c3&tochange=d1d7f3f326004ec34e743392f33998d4b1c625e2&selectedJob=180049629

Failure log: 
https://treeherder.mozilla.org/logviewer.html#?job_id=180063599&repo=mozilla-inbound&lineNumber=22175
https://treeherder.mozilla.org/logviewer.html#?job_id=180036539&repo=mozilla-inbound&lineNumber=18285

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/d1d7f3f32600

Comment 8

[Thomas Wisniewski [:twisniewski]]

Note that I was working on this in bug 1403027, which I'm presently trying to land (sorry, I just found this bug).

Comment 9

[Thomas Wisniewski [:twisniewski]]

baku, it looks like bug 1403027 has landed. It looks like this one be closed a duplicate?

Comment 11

[Chris Mills [:cmills]]

Removing DDN, as this is a Dupe