Closed
Bug 1463012
Opened 6 years ago
Closed 6 years ago
Use Node.contains instead of isAncestorOrSelf
Categories
(WebExtensions :: General, enhancement)
WebExtensions
General
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: Oriol, Assigned: Oriol)
References
Details
Attachments
(1 file)
ext-browserAction defines a isAncestorOrSelf function which checks whether a node is an inclusive descendant of another. The native Node.contains does the same, so better use that instead.
| Comment hidden (mozreview-request) |
|
||
Comment 2•6 years ago
|
||
| mozreview-review | ||
Comment on attachment 8979127 [details] Bug 1463012 - Use Node.contains instead of isAncestorOrSelf https://reviewboard.mozilla.org/r/245358/#review251492 lgtm and the tests from bug 1287209 should cover this.
Attachment #8979127 -
Flags: review?(mixedpuppy) → review+
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5d49624da2d5 Use Node.contains instead of isAncestorOrSelf r=mixedpuppy
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5d49624da2d5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
|
||
Updated•6 years ago
|
Flags: qe-verify-
|
||
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•