1463035 - Remove MOZ_SIGNAL_TRAMPOLINE

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Mike Hommey [:glandium]]

For some reason, GNU as is not happy with the assembly generated after bug 1238661 anymore on Debian armel.

OTOH, as mentioned in bug 1238661 comment 4, we actually don't need this workaround anymore, so let's just kill it.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1463035 - Remove MOZ_SIGNAL_TRAMPOLINE.

For some reason, GNU as is not happy with the assembly generated after
bug 1238661 anymore on Debian armel.

OTOH, as mentioned in bug 1238661 comment 4, we actually don't need this
workaround anymore, so let's just kill it.

Review commit: https://reviewboard.mozilla.org/r/245410/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245410/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8979154 [details]
Bug 1463035 - Remove MOZ_SIGNAL_TRAMPOLINE.

https://reviewboard.mozilla.org/r/245410/#review251496

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98e368b5c4be
Remove MOZ_SIGNAL_TRAMPOLINE. r=jchen

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 98e368b5c4be (bug 1463035) for failures in tools/profiler/tests/chrome/test_profile_worker.html on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5e5ef53eee5b69f9be604029afa46ba0afb75966&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=179565995

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=179565995&repo=autoland&lineNumber=2364

Backout: https://hg.mozilla.org/integration/autoland/rev/0ee7d4aa1799029d38c95d75eefe4a401cbd2800

Comment 5

[Mike Hommey [:glandium]]

WTH?

Comment 6

[Mike Hommey [:glandium]]

[task 2018-05-21T23:58:29.010Z] 23:58:29     INFO -  Operating system: Android
[task 2018-05-21T23:58:29.010Z] 23:58:29     INFO -                    0.0.0 Linux 2.6.29-gea477bb #1 Wed Sep 26 11:04:45 PDT 2012 armv7l

OMG why are we running tests on images using such an old kernel!?

Comment 7

[(inactive) Jim Chen [:jchen] [:darchons]]

Sounds like it might be time to switch to a newer AVD

Comment 8

[Geoff Brown [:gbrown]]

We went a long time (a couple of years?) where newer versions of the emulator were not compatible with aws, and it was not possible (certainly not straight-forward) to update the avd system images without updating the emulator. Now, it is possible to upgrade the emulator and avd, but last I checked, for armv7/4.3, the result was over-all slightly slower than the existing version, introduced many reftest and a few mochitest failures, and offered no known advantages over the existing setup. I need to check on that again - bug 1455485 - but first I need to figure out what's wrong with the latest emulator - bug 1463909. For geckoview, we intend to get around this nonsense by running geckoview tests on a kvm-accelerated x86 emulator running Android 7.0: bug 1460411. But little consideration has been given to updating the existing Firefox for Android test environment, beyond, "let's see how that geckoview plan works out".

I guess I'm saying: This is an inconvenient time to update the Firefox for Android test environment, and it is not easy. How important and urgent is an OS update? Also, what is the minimum target version, or how can I determine if a given Android is helpful to this bug?

Comment 9

[(inactive) Jim Chen [:jchen] [:darchons]]

(In reply to Geoff Brown [:gbrown] from comment #8)
> I guess I'm saying: This is an inconvenient time to update the Firefox for
> Android test environment, and it is not easy. How important and urgent is an
> OS update? Also, what is the minimum target version, or how can I determine
> if a given Android is helpful to this bug?

I think we just need something with a newer kernel than 2.6.29. For example, the mozemulator-4.3 AVD (from `mach android-emulator` but not used in automation) has a newer 3.4.67 kernel.

Comment 10

[Geoff Brown [:gbrown]]

Thanks. Let's discuss next steps for an android upgrade in bug 1455485.

Comment 12

[Mike Hommey [:glandium]]

Attachment: Bug 1463035 - Remove MOZ_SIGNAL_TRAMPOLINE.

This was previously r=jchen and landed, but was backed out because some
Android tests were running on an unrealistically old Linux kernel. These
tests have been retired, so this can reland.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74444d8237d1
Remove MOZ_SIGNAL_TRAMPOLINE. r=gerald

Comment 14

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/74444d8237d1