Closed
Bug 1463084
Opened 7 years ago
Closed 7 years ago
Font editor: Consider supporting TextNode
Categories
(DevTools :: Inspector, defect, P3)
DevTools
Inspector
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: rcaliman, Assigned: rcaliman)
References
Details
Attachments
(1 file)
As a result of Bug 1463055, plain TextNodes are no longer supported by the Font Editor. An ElementNode is required in order to read properties from its computed style and write properties to its inline style, something TextNodes do not have.
This change caused the following test to fail (removed until further action is taken):
devtools/client/inspector/fonts/test/browser_fontinspector_text-node.js
Removed test source copied below:
const TEST_URI = URL_ROOT + "browser_fontinspector.html";
add_task(async function() {
let { inspector, view } = await openFontInspectorForURL(TEST_URI);
let viewDoc = view.document;
info("Selecting the first text-node first-child of <body>");
let bodyNode = await getNodeFront("body", inspector);
let { nodes } = await inspector.walker.children(bodyNode);
await selectNode(nodes[0], inspector);
let lis = getUsedFontsEls(viewDoc);
is(lis.length, 1, "Font inspector shows 1 font");
});
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8990950 [details]
Bug 1463084 - Invoke the font editor on the parent node of a text node selection.
https://reviewboard.mozilla.org/r/255936/#review263114
::: devtools/client/inspector/fonts/test/browser_fontinspector_text-node.js:4
(Diff revision 1)
> +/* vim: set ts=2 et sw=2 tw=80: */
> +/* Any copyright is dedicated to the Public Domain.
> + http://creativecommons.org/publicdomain/zero/1.0/ */
> +"use strict";
Add a new line before "use strict"
Attachment #8990950 -
Flags: review?(gl) → review+
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s f10ea2e90a9908dbee7590910b2c068c4b795d78 -d e4d608a4a833: rebasing 472488:f10ea2e90a99 "Bug 1463084 - Invoke the font editor on the parent node of a text node selection. r=gl" (tip)
merging devtools/client/inspector/fonts/fonts.js
warning: conflicts while merging devtools/client/inspector/fonts/fonts.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
| Comment hidden (mozreview-request) |
|
|
||
Comment 6•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 86fd180ff83e2a0063d1ef9795c00d85ba2a7dd1 -d 3e71248ff093: rebasing 472497:86fd180ff83e "Bug 1463084 - Invoke the font editor on the parent node of a text node selection. r=gl" (tip)
merging devtools/client/inspector/fonts/fonts.js
warning: conflicts while merging devtools/client/inspector/fonts/fonts.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
| Comment hidden (mozreview-request) |
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fa2eaa73b356
Invoke the font editor on the parent node of a text node selection. r=gl
|
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
|
||
Updated•4 years ago
|
Component: Inspector: Fonts → Inspector
You need to log in
before you can comment on or make changes to this bug.
Description
•