1463085 - Possibly unnecessary self-assign in testing/marionette/listener.js

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Mark Banner (:standard8)]

This is being picked up by ESLint 5 which we haven't got in the tree yet, but I'm testing out the early versions.

testing/marionette/listener.js
  1154:22  error  'opts.startNode' is assigned to itself.  no-self-assign (eslint)

Coming from here:

https://searchfox.org/mozilla-central/rev/8affe6e83188787eb61fe0528eeb6eef6081ba06/testing/marionette/listener.js#1154

This code was last changed by bug 1400256 and it looks like it might now be an unnecessary assignment, but I'm not totally sure.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1463085 - Remove unnecessary self-assignment.

Prior to bug 1400256 we used to have to deserialise the web
element received from chrome space manually, and presumably this
self-assignment is a leftover from that time.

This fixes an eslint error upon upgrading to eslint version 5.

Thanks-to: Mark Banner <[e-mail]>

Review commit: https://reviewboard.mozilla.org/r/245442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245442/

Comment 2

[Andreas Tolfsen ❲:ato❳]

This is a leftover from when we used to have to deserialise the web
element passed from chrome space ourselves.

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8979212 [details]
Bug 1463085 - Remove unnecessary self-assignment.

https://reviewboard.mozilla.org/r/245442/#review251940

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/032d683ed7e7
Remove unnecessary self-assignment. r=maja_zf

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/032d683ed7e7