Closed Bug 1463089 Opened 6 years ago Closed 6 years ago

Remove deprecated experimentalObjectRestSpread option from netmonitor's .eslintrc.js file, and clean it up

Categories

(DevTools :: Netmonitor, enhancement)

enhancement
Not set
normal

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Netmonitor is currently defining in .eslintrc.js some options that will soon be going out of date (namely experimentalObjectRestSpread).

ESLint 5 raises a deprecation warning for that.

Additionally, there's some other configuration that is inherited from higher level directories, but isn't necessary as ESLint does that automatically. I believe some other devtools files used to do this to aid local configurations, but they were changed to make everything a lot simpler.
Comment on attachment 8979641 [details]
Bug 1463089 - Remove deprecated experimentalObjectRestSpread option from netmonitor's .eslintrc.js file, and clean it up.

https://reviewboard.mozilla.org/r/245784/#review252092

Thanks for the patch Mark!

Works for me, R+

Honza
Attachment #8979641 - Flags: review?(odvarko) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/87ceff81c3ed
Remove deprecated experimentalObjectRestSpread option from netmonitor's .eslintrc.js file, and clean it up. r=Honza
https://hg.mozilla.org/mozilla-central/rev/87ceff81c3ed
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: