1463230 - gfxMacFont.cpp error: using integer absolute value function 'abs' when argument is of floating point type

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

+++ This bug was initially created as a clone of Bug #1457417 +++

Nightly no longer compiles for me on OSX 10.12.6 (16G29)

 0:08.52 /Users/Jan/moz/mozilla-central/gfx/thebes/gfxMacFont.cpp:100:21: error: using integer absolute value function 'abs' when argument is of floating point type [-Werror,-Wabsolute-value]
 0:08.52                 if (abs(value - axis.mDefaultValue) < 0.001f) {
 0:08.52                     ^
 0:08.52 /Users/Jan/moz/mozilla-central/gfx/thebes/gfxMacFont.cpp:100:21: note: use function 'std::abs' instead
 0:08.52                 if (abs(value - axis.mDefaultValue) < 0.001f) {
 0:08.52                     ^~~
 0:08.52                     std::abs
 0:08.52 1 error generated.
 0:08.52 make[4]: *** [gfxMacFont.o] Error 1

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1463230 - Fix compile error on abs(float). Use std::abs() instead.

Review commit: https://reviewboard.mozilla.org/r/245514/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245514/

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 8979359 [details]
Bug 1463230 - Fix compile error on abs(float). Use std::abs() instead.

https://reviewboard.mozilla.org/r/245514/#review251542

Stealing review from jwatt - this looks fine, thanks.

Comment 3

[Jonathan Kew [:jfkthame]]

Comment on attachment 8979359 [details]
Bug 1463230 - Fix compile error on abs(float). Use std::abs() instead.

https://reviewboard.mozilla.org/r/245514/#review251544

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9afdceeddbf
Fix compile error on abs(float). Use std::abs() instead. r=jfkthame

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b9afdceeddbf