146328 - PluginViewerImpl::Init(nsIWidget* aParentWidget == check this parameter for null

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[serge (gone)]

this particular checkin  for bug 52334
RCS file: /cvsroot/mozilla/docshell/base/nsDocShell.cpp,v
retrieving revision 1.446
...
@@ -4349,13 +4364,13 @@
 
     nsCOMPtr<nsIWidget> widget;
     NS_ENSURE_SUCCESS(GetMainWidget(getter_AddRefs(widget)), NS_ERROR_FAILURE);
-    if (!widget) {
-        NS_ERROR("GetMainWidget coughed up a null widget");
-        return NS_ERROR_FAILURE;
+
+    if (widget) {
+        NS_ENSURE_SUCCESS(EnsureDeviceContext(), NS_ERROR_FAILURE);
     }
     nsRect bounds(x, y, cx, cy);
-    NS_ENSURE_SUCCESS(EnsureDeviceContext(), NS_ERROR_FAILURE);
+
     if (NS_FAILED(mContentViewer->Init(widget, mDeviceContext, bounds))) {

are causing the crash in PluginViewerImpl::Init(nsIWidget* aParentWidget,
when *aParentWidget==null

there are several TB incidents with such crash:
Incident 6244440 - Stacktrace:
http://climate.mcom.com/reports/singleincidentinfo.cfm?dynamicBBID=6244440
    Email: [e-mail]
Incident 6244469 - Stacktrace:
http://climate.mcom.com/reports/singleincidentinfo.cfm?dynamicBBID=6244469
    Email: [e-mail]
Incident 6244663 - Stacktrace:
http://climate.mcom.com/reports/singleincidentinfo.cfm?dynamicBBID=6244663
    Email: [e-mail]
Incident 6244687 - Stacktrace:
http://climate.mcom.com/reports/singleincidentinfo.cfm?dynamicBBID=6244687
    Email: [e-mail]
---
the fix is abviuos:
cvs diff -u nsPluginViewer.cpp
Index: nsPluginViewer.cpp
===================================================================
RCS file: /cvsroot/mozilla/modules/plugin/base/src/nsPluginViewer.cpp,v
retrieving revision 1.115
diff -u -r1.115 nsPluginViewer.cpp
--- nsPluginViewer.cpp  20 May 2002 03:29:48 -0000      1.115
+++ nsPluginViewer.cpp  22 May 2002 21:59:01 -0000
@@ -323,6 +323,8 @@
                        nsIDeviceContext* aDeviceContext,
                        const nsRect& aBounds)
 {
+  NS_ENSURE_TRUE(aParentWidget, NS_ERROR_NULL_POINTER);
+
   nsresult rv = MakeWindow(aParentWidget->GetNativeData(NS_NATIVE_WIDGET),
    aDeviceContext, aBounds);
   if (NS_OK == rv) {

Comment 1

[serge (gone)]

Attachment: patch v1

Comment 2

[Peter Lubczynski]

Comment on attachment 84711 [details] [diff] [review]
patch v1

r=peterl

Comment 3

[av (gone)]

Comment on attachment 84711 [details] [diff] [review]
patch v1

r=av

Comment 4

[serge (gone)]

Patrick, could you please sr=
Thanks.

Comment 5

[Patrick C. Beard]

Comment on attachment 84711 [details] [diff] [review]
patch v1

sr=beard

Comment 6

[Jaime Rodriguez, Jr.]

Nominating for nsbeta1+, as this has been marked as ADT1 RTM, and [PL RTM].

Comment 7

[serge (gone)]

on the trunk
mozilla/modules/plugin/base/src/nsPluginViewer.cpp,v  <--  nsPluginViewer.cpp
new revision: 1.116; previous revision: 1.115

Comment 8

[serge (gone)]

nominating

Comment 9

[scottputterman]

adding adt1.0.1+.  Please get drivers approval before checking into the branch.

Comment 10

[serge (gone)]

request for a= has been sent to [e-mail] 
on Mon, 10 Jun 2002 17:55:59

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 84711 [details] [diff] [review]
patch v1

Please land this on the 1.0.1 branch.  Once there, remove the
"mozilla1.0.1+" keyword, and add the "fixed1.0.1"

Comment 12

[serge (gone)]

cheched in on MOZILLA_1_0_BRANCH
mozilla/modules/plugin/base/src/nsPluginViewer.cpp,v  <--  nsPluginViewer.cpp
new revision: 1.106.2.8; previous revision: 1.106.2.7

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

added +

Comment 14

[shrirang khanzode]

v