1463408 - Allow profiler to disable parallel traversal of stylo

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+10]

That would make it clearer what's going on inside the restyle phase.

It seems we can easily disable that via ServoStyleSet::ShouldTraverseInParallel(). We need to add a runtime switch somewhere, and have Gecko Profiler add a new checkbox for this.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1463408 part 1 - Remove unused restyle profiler feature.

Review commit: https://reviewboard.mozilla.org/r/246070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246070/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1463408 part 2 - Add profiler feature seqstyle for forcing sequential styling when profiling.

Review commit: https://reviewboard.mozilla.org/r/246072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246072/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

The change to addon is on devtools-html/Gecko-Profiler-Addon#118.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8979879 [details]
Bug 1463408 part 2 - Add profiler feature seqstyle for forcing sequential styling when profiling.

https://reviewboard.mozilla.org/r/246072/#review252202

::: layout/style/ServoStyleSet.cpp:1521
(Diff revision 1)
>    MOZ_ASSERT(mDocument->GetShell(), "Styling a document without a shell?");
> -  return mDocument->GetShell()->IsActive();
> +  if (!mDocument->GetShell()->IsActive()) {
> +    return false;
> +  }
> +#ifdef MOZ_GECKO_PROFILER
> +  if (profiler_feature_active(ProfilerFeature::SequentialStyle)) {

I'm slightly disappointed this add a function call and a sequentially-consistent operation in this function, but it's fine I think, it's not the hottest code in the world :).

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8979878 [details]
Bug 1463408 part 1 - Remove unused restyle profiler feature.

https://reviewboard.mozilla.org/r/246070/#review252320

Thanks for taking care of bug 1452753 :)

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8979878 [details]
Bug 1463408 part 1 - Remove unused restyle profiler feature.

https://reviewboard.mozilla.org/r/246070/#review252322

Oh, you'll also need to remove the feature from https://searchfox.org/mozilla-central/source/browser/components/extensions/schemas/geckoProfiler.json , otherwise this test is going to fail: https://searchfox.org/mozilla-central/rev/eb51d734a8c06ac5973291be9bcc74ed4e999bca/browser/components/extensions/test/xpcshell/test_ext_geckoProfiler_schema.js#33-42

Comment 7

[Markus Stange [:mstange]]

Comment on attachment 8979879 [details]
Bug 1463408 part 2 - Add profiler feature seqstyle for forcing sequential styling when profiling.

https://reviewboard.mozilla.org/r/246072/#review252324

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8979878 [details]
Bug 1463408 part 1 - Remove unused restyle profiler feature.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246070/diff/1-2/

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8979879 [details]
Bug 1463408 part 2 - Add profiler feature seqstyle for forcing sequential styling when profiling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246072/diff/1-2/

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8979878 [details]
Bug 1463408 part 1 - Remove unused restyle profiler feature.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246070/diff/2-3/

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8979879 [details]
Bug 1463408 part 2 - Add profiler feature seqstyle for forcing sequential styling when profiling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246072/diff/2-3/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d3f94ce4109
part 1 - Remove unused restyle profiler feature. r=mstange
https://hg.mozilla.org/integration/autoland/rev/e0c02a6f05dd
part 2 - Add profiler feature seqstyle for forcing sequential styling when profiling. r=emilio,mstange

Comment 13

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/7d3f94ce4109
https://hg.mozilla.org/mozilla-central/rev/e0c02a6f05dd