1463440 - Support FTP over TLS/SSL (ftps://) URLs in MatchPattern

Status: RESOLVED WONTFIX

(WebExtensions :: Request Handling, enhancement, P5)

Description

[ExE Boss]

Right now, MatchPattern permits ftp://, but not FTP over TLS (ftps://) URLs, which is in contrast to http:// also permitting HTTP over TLS (https://).

This bug serves to track the work necessary to add ftps:// to the list of valid WebExtension MatchPattern schemes.

Comment 1

[Tim Nguyen :ntim]

The list of allowed schemes is here: https://searchfox.org/mozilla-central/source/toolkit/components/extensions/MatchPattern.cpp#266

if you're interested in contributing a patch :)

Comment 2

[Caitlin Neiman [:caitmuenster]]

Mentor: Shane Caraveo (:mixedpuppy) 

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Given comments in bug 85464, closing.

Comment 4

[ExE Boss]

Attachment: Bug 1463440 - Add FTP over TLS/SSL (ftps://) URLs to MatchPattern

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8998394 [details]
Bug 1463440 - Add FTP over TLS/SSL (ftps://) URLs to MatchPattern

Shane Caraveo (:mixedpuppy) has approved the revision.

Comment 6

[ExE Boss]

Re‑opening, as :mixedpuppy approved this.

Comment 7

[Tim Nguyen :ntim]

Does Firefox actually support FTPS ? If not, there's no point adding this to WebExtensions.

Comment 8

[ExE Boss]

(In reply to Tim Nguyen :ntim from comment #7)
> Does Firefox actually support FTPS ?

Implementation of FTPS is tracked in bug 85464, which :ckerschb closed in bug 85464 comment 35 ☹️

> If not, there's no point adding this to WebExtensions.

As I said in the patch on Phabricator (https://phabricator.services.mozilla.com/D2899#65206), this will at least allow WebExtensions to use the `browser.webRequest` API to intercept FTPS calls.

Also, even if this doesn’t end up actually doing anything, at least we won’t forget to add it to MatchPattern as part of bug 85464.

Comment 9

[Tim Nguyen :ntim]

OK, it should probably be documented then.

Comment 10

[ExE Boss]

(In reply to Tim Nguyen :ntim from comment #9)
> OK, it should probably be documented then.

Way ahead of you (all done within a week of opening this bug):
- https://github.com/mdn/browser-compat-data/commit/b8c7e1b9133d6dafc479fd140ba55ae3b0bf85d2
- https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns#scheme
- https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns#Examples
- https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns#Browser_compatibility

Comment 11

[Shane Caraveo (:mixedpuppy)]

(In reply to ExE Boss from comment #8)
> (In reply to Tim Nguyen :ntim from comment #7)
> > Does Firefox actually support FTPS ?
> 
> Implementation of FTPS is tracked in bug 85464, which :ckerschb closed in
> bug 85464 comment 35 ☹️
> 
> > If not, there's no point adding this to WebExtensions.
> 
> As I said in the patch on Phabricator
> (https://phabricator.services.mozilla.com/D2899#65206), this will at least
> allow WebExtensions to use the `browser.webRequest` API to intercept FTPS
> calls.
> 
> Also, even if this doesn’t end up actually doing anything, at least we won’t
> forget to add it to MatchPattern as part of bug 85464.

There goes my lack of proper cafination in the morning.  Since we don't actually support ftps then we probably shouldn't add it to matchpattern in a way that makes it potentially work with permissions in a manifest.  So basically, sorry, lets hold off unless there is an actual working use case.

Comment 12

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8998394 [details]
Bug 1463440 - Add FTP over TLS/SSL (ftps://) URLs to MatchPattern

removing r+

Comment 13

[Shane Caraveo (:mixedpuppy)]

Going back to comment 3 and closing again.