1463483 - Regression test for bootstrap process performance

Status: RESOLVED FIXED

(Testing :: Talos, enhancement)

Description

[(No longer employed by Mozilla) Aaron Klotz]

I want to measure a couple of things, and I think using our existing xperf infra is the way to do it:

1) Time from launcher process creation to session restore event;
2) Time from launcher process creation to browser process main thread resumption.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Aaron Klotz [:aklotz] from comment #0)
> I want to measure a couple of things, and I think using our existing xperf
> infra is the way to do it:
> 
> 1) Time from launcher process creation to session restore event;

This is the most important one. I'm skipping (2) for now. We could potentially throw that into a follow-up bug.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Add session restore timing analysis

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Add session restore timing analysis (r2)

Whoops, the first revision was missing a piece. This one is fixed.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9000047 [details] [diff] [review]
Add session restore timing analysis (r2)

Review of attachment 9000047 [details] [diff] [review]:
-----------------------------------------------------------------

my main question is do we expect session_store data to exist?  xperf runs in tp5 where we launch the browser, interate once through 100 pages, then close the browser- do we need to make a sessionstore test case, or does the existing case provide enough data?

::: testing/talos/talos/results.py
@@ +501,5 @@
> +            # obtain the value by converting the second line in the file.
> +            with open(filename, 'r') as contents:
> +                lines = contents.read().splitlines()
> +                value = float(lines[1].strip())
> +                counter_results.setdefault(session_store_counter, []).append(value)

I want to understand if we have an array of data we expect or just a single data point.

::: testing/talos/talos/xtalos/parse_xperf.py
@@ +21,5 @@
> +    for r in required:
> +        if r not in kwargs:
> +            raise xtalos.XTalosError('%s required' % r)
> +
> +    finaloutputfile = "%s_session_restore_stats%s" % os.path.splitext(

this code has a mix of camelCase and _ variable names, lets chose one and use that, I think _ is more common, so final_output_file would be a better variable name.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

(In reply to Joel Maher ( :jmaher ) (UTC+2) from comment #4)
> Comment on attachment 9000047 [details] [diff] [review]
> Add session restore timing analysis (r2)
> 
> Review of attachment 9000047 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> my main question is do we expect session_store data to exist?  xperf runs in
> tp5 where we launch the browser, interate once through 100 pages, then close
> the browser- do we need to make a sessionstore test case, or does the
> existing case provide enough data?

Yes, the "session store window restored" event the same event that is used to distinguish between the "startup" and "normal" stages in the existing etlparser code.

* Note: In order for xperf to be able to "see" events generated by Firefox, https://searchfox.org/mozilla-central/source/toolkit/components/startup/mozprofilerprobe.mof needs to be installed on the machine running xperf. This was the case in the previous setup, but I'm not sure if anything needs to be done for TaskCluster.

> 
> ::: testing/talos/talos/results.py
> @@ +501,5 @@
> > +            # obtain the value by converting the second line in the file.
> > +            with open(filename, 'r') as contents:
> > +                lines = contents.read().splitlines()
> > +                value = float(lines[1].strip())
> > +                counter_results.setdefault(session_store_counter, []).append(value)
> 
> I want to understand if we have an array of data we expect or just a single
> data point.

It would just be a single data point, representing how long it took Firefox from initial process creation to the displaying of its window.

> 
> ::: testing/talos/talos/xtalos/parse_xperf.py
> @@ +21,5 @@
> > +    for r in required:
> > +        if r not in kwargs:
> > +            raise xtalos.XTalosError('%s required' % r)
> > +
> > +    finaloutputfile = "%s_session_restore_stats%s" % os.path.splitext(
> 
> this code has a mix of camelCase and _ variable names, lets chose one and
> use that, I think _ is more common, so final_output_file would be a better
> variable name.

Sure, will fix.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

we do have the mozprofilerprobe.mof already installed, if we need to update it (from years ago) please be specific about it so we can update our test machines.

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Nothing has changed there, so we should be okay.

Comment 8

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Add session restore timing analysis (r3)

This revision addresses your comment about naming and also ensures that the debug flag is propagated to XPerfFile.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 9001396 [details] [diff] [review]
Add session restore timing analysis (r3)

Review of attachment 9001396 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for doing this, looking forward to getting xperf updated (I think next week is more realistic as I need taskcluster help and there is PTO mixed in there)

Comment 10

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5c898a4aaafedae7c53131adb5ca910c054df85
Bug 1463483: Add session store analysis to xperf; r=jmaher

Comment 11

[Cosmin Sabou [:CosminS]]

Backed out  for causing talos xperf failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=Windows%207%20opt%20Talos%20performance%20tests%20with%20e10s%20test-windows7-32%2Fopt-talos-xperf-e10s%20T-e10s(x)&fromchange=d5c898a4aaafedae7c53131adb5ca910c054df85&tochange=c99d9b6ba765993b58f8570e9ad62d5f5dbcea1a&selectedJob=194628367

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194629085&repo=mozilla-inbound&lineNumber=720

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/c99d9b6ba765993b58f8570e9ad62d5f5dbcea1a

23:36:19    ERROR -  about:support	{"application":{"name":"Firefox","osVersion":"Windows_NT 6.1","version":"63.0a1","buildID":"20180817201318","userAgent":"Mozilla/5.0 (Windows NT 6.1; rv:63.0) Gecko/20100101 Firefox/63.0","safeMode":false,"updateChannel":"default","supportURL":"https://support.mozilla.org/1/firefox/63.0a1/WINNT/en-US/","numTotalWindows":2,"numRemoteWindows":2,"remoteAutoStart":true,"currentContentProcesses":4,"maxContentProcesses":4,"autoStartStatus":1,"policiesStatus":0,"keyGoogleFound":true,"keyMozillaFound":true},"securitySoftware":{"registeredAntiVirus":"","registeredAntiSpyware":"","registeredFirewall":""},"modifiedPreferences":{"browser.cache.disk.filesystem_reported":1,"browser.cache.disk.smart_size.enabled":false,"browser.cache.disk.smart_size.first_run":false,"browser.link.open_newwindow":2,"browser.sessionstore.resume_from_crash":false,"browser.startup.homepage_override.mstone":"63.0a1","browser.startup.homepage_override.buildID":"20180817201318","browser.tabs.remote.autostart":true,"browser.tabs.warnOnClose":false,"browser.urlbar.userMadeSearchSuggestionsChoice":true,"dom.allow_scripts_to_close_windows":true,"dom.disable_open_during_load":false,"dom.disable_window_flip":true,"dom.disable_window_move_resize":true,"dom.forms.autocomplete.formautofill":true,"dom.max_chrome_script_run_time":0,"dom.max_script_run_time":0,"dom.send_after_paint_to_content":true,"extensions.checkCompatibility":false,"extensions.lastAppVersion":"63.0a1","general.useragent.updates.enabled":false,"gfx.direct2d.disabled":true,"layers.mlgpu.sanity-test-failed":false,"media.allowed-to-play.enabled":true,"media.autoplay.ask-permission":false,"media.autoplay.block-webaudio":false,"media.autoplay.default":0,"media.autoplay.enabled.user-gestures-needed":true,"media.capturestream_hints.enabled":true,"media.gmp-manager.updateEnabled":false,"media.gmp-manager.url":"http://127.0.0.1/gmpmanager-dummy/update.xml","media.gmp.storage.version.observed":1,"media.hardware-video-decoding.failed":false,"media.libavcodec.allow-obsolete":true,"media.navigator.enabled":true,"media.navigator.permission.disabled":true,"media.peerconnection.enabled":true,"network.http.speculative-parallel-limit":0,"places.database.lastMaintenance":2147483647,"places.history.expiration.transient_current_max_pages":112348,"plugin.state.flash":0,"plugins.flashBlock.enabled":false,"privacy.reduceTimerPrecision":false,"privacy.trackingprotection.annotate_channels":false,"privacy.trackingprotection.enabled":false,"privacy.trackingprotection.introURL":"http://127.0.0.1/trackingprotection/tour","privacy.trackingprotection.pbmode.enabled":false,"security.enable_java":false,"security.fileuri.strict_origin_policy":false,"security.notification_enable_delay":0,"security.sandbox.content.tempDirSuffix":"{16d3c2ef-ecea-4a02-b81c-3a291043949f}","security.turn_off_all_security_so_that_viruses_can_take_over_this_computer":true,"services.sync.engine.addresses.available":true,"services.sync.engine.creditcards.available":true},"lockedPreferences":{},"media":{"currentAudioBackend":"wasapi","currentMaxAudioChannels":2,"currentPreferredSampleRate":44100,"audioOutputDevices":[{"name":"Line 1 (Virtual Audio Cable)","groupId":"Root\\MEDIA\\0000","vendor":"","type":2,"state":2,"preferred":7,"supportedFormat":4112,"defaultFormat":4096,"maxChannels":2,"defaultRate":44100,"maxRate":44100,"minRate":44100,"maxLatency":441,"minLatency":133}],"audioInputDevices":[{"name":"Line 1 (Virtual Audio Cable)","groupId":"Root\\MEDIA\\0000","vendor":"","type":1,"state":2,"preferred":7,"supportedFormat":4112,"defaultFormat":4096,"maxChannels":2,"defaultRate":44100,"maxRate":44100,"minRate":44100,"maxLatency":441,"minLatency":133},{"name":"Mic 1 (Virtual Audio Cable)","groupId":"Root\\MEDIA\\0000","vendor":"","type":1,"state":1,"preferred":0,"supportedFormat":4112,"defaultFormat":4096,"maxChannels":0,"defaultRate":0,"maxRate":0,"minRate":0,"maxLatency":0,"minLatency":0},{"name":"S/PDIF 1 (Virtual Audio Cable)","groupId":"Root\\MEDIA\\0000","vendor":"","type":1,"state":1,"preferred":0,"supportedFormat":4112,"defaultFormat":4096,"maxChannels":0,"defaultRate":0,"maxRate":0,"minRate":0,"maxLatency":0,"minLatency":0}]},"javaScript":{"incrementalGCEnabled":true},"accessibility":{"isActive":false,"forceDisabled":0,"handlerUsed":false,"instantiator":""},"libraryVersions":{"NSPR":{"minVersion":"4.20 Beta","version":"4.20 Beta"},"NSS":{"minVersion":"3.39 Beta","version":"3.39 Beta"},"NSSUTIL":{"minVersion":"3.39 Beta","version":"3.39 Beta"},"NSSSSL":{"minVersion":"3.39 Beta","version":"3.39 Beta"},"NSSSMIME":{"minVersion":"3.39 Beta","version":"3.39 Beta"}},"userJS":{"exists":true},"intl":{"localeService":{"requested":["en-US"],"available":["en-US"],"supported":["en-US"],"regionalPrefs":["en-US"],"defaultLocale":"en-US"},"osPrefs":{"systemLocales":["en-US"],"regionalPrefsLocales":["en-US"]}},"crashes":{"submitted":[],"pending":0},"sandbox":{"contentSandboxLevel":5,"effectiveContentSandboxLevel":5},"graphics":{"numTotalWindows":3,"numAcceleratedWindows":0,"windowLayerManagerType":"Basic","windowLayerManagerRemote":true,"windowUsingAdvancedLayers":false,"numAcceleratedWindowsMessage":["blockedGfxCard"],"adapterDescription":"VirtualMonitor Graphics Adapter","adapterVendorID":"0x000a","adapterDeviceID":"0x000a","adapterSubsysID":"0000000a","adapterRAM":"Unknown","adapterDrivers":"VirtualMonitorDisp","driverVersion":"","driverDate":"","adapterDescription2":"","adapterVendorID2":"","adapterDeviceID2":"","adapterSubsysID2":"","adapterRAM2":"","adapterDrivers2":"","driverVersion2":"","driverDate2":"","isGPU2Active":false,"direct2DEnabled":false,"directWriteEnabled":true,"directWriteVersion":"6.1.7601.17514","usesTiling":false,"contentUsesTiling":true,"offMainThreadPaintEnabled":true,"offMainThreadPaintWorkerCount":4,"direct2DEnabledMessage":["blockedGfxCard"],"webgl1Renderer":"Google Inc. -- ANGLE (Software Adapter Direct3D11 vs_4_1 ps_4_1)","webgl1Version":"OpenGL ES 2.0 (ANGLE 2.1.0.ae3b5a6552ee)","webgl1DriverExtensions":"GL_ANGLE_client_arrays GL_ANGLE_depth_texture GL_ANGLE_explicit_context GL_ANGLE_explicit_context_gles1 GL_ANGLE_framebuffer_blit GL_ANGLE_framebuffer_multisample GL_ANGLE_instanced_arrays GL_ANGLE_lossy_etc_decode GL_ANGLE_pack_reverse_row_order GL_ANGLE_program_cache_control GL_ANGLE_request_extension GL_ANGLE_robust_client_memory GL_ANGLE_texture_compression_dxt3 GL_ANGLE_texture_compression_dxt5 GL_ANGLE_texture_usage GL_ANGLE_translated_shader_source GL_CHROMIUM_bind_generates_resource GL_CHROMIUM_bind_uniform_location GL_CHROMIUM_color_buffer_float_rgb GL_CHROMIUM_color_buffer_float_rgba GL_CHROMIUM_copy_compressed_texture GL_CHROMIUM_copy_texture GL_CHROMIUM_sync_query GL_EXT_blend_minmax GL_EXT_color_buffer_half_float GL_EXT_debug_marker GL_EXT_discard_framebuffer GL_EXT_disjoint_timer_query GL_EXT_draw_buffers GL_EXT_frag_depth GL_EXT_map_buffer_range GL_EXT_occlusion_query_boolean GL_EXT_read_format_bgra GL_EXT_robustness GL_EXT_sRGB GL_EXT_shader_texture_lod GL_EXT_texture_compression_dxt1 GL_EXT_texture_compression_s3tc_srgb GL_EXT_texture_filter_anisotropic GL_EXT_texture_format_BGRA8888 GL_EXT_texture_rg GL_EXT_texture_storage GL_EXT_unpack_subimage GL_KHR_debug GL_KHR_robust_buffer_access_behavior GL_NV_EGL_stream_consumer_external GL_NV_fence GL_NV_pack_subimage GL_NV_pixel_buffer_object GL_OES_EGL_image GL_OES_EGL_image_external GL_OES_compressed_ETC1_RGB8_texture GL_OES_depth32 GL_OES_element_index_uint GL_OES_get_program_binary GL_OES_mapbuffer GL_OES_packed_depth_stencil GL_OES_rgb8_rgba8 GL_OES_standard_derivatives GL_OES_surfaceless_context GL_OES_texture_float GL_OES_texture_float_linear GL_OES_texture_half_float GL_OES_texture_half_float_linear GL_OES_texture_npot GL_OES_vertex_array_object OES_compressed_EAC_R11_signed_texture OES_compressed_EAC_R11_unsigned_texture OES_compressed_EAC_RG11_signed_texture OES_compressed_EAC_RG11_unsigned_texture OES_compressed_ETC2_RGB8_texture OES_compressed_ETC2_RGBA8_texture OES_compressed_ETC2_punchthroughA_RGBA8_texture OES_compressed_ETC2_punchthroughA_sRGB8_alpha_texture OES_compressed_ETC2_sRGB8_alpha8_texture OES_compressed_ETC2_sRGB8_texture ","webgl1Extensions":"ANGLE_instanced_arrays EXT_blend_minmax EXT_color_buffer_half_float EXT_frag_depth EXT_sRGB EXT_shader_texture_lod EXT_texture_filter_anisotropic EXT_disjoint_timer_query OES_element_index_uint OES_standard_derivatives OES_texture_float OES_texture_float_linear OES_texture_half_float OES_texture_half_float_linear OES_vertex_array_object WEBGL_color_buffer_float WEBGL_compressed_texture_s3tc WEBGL_compressed_texture_s3tc_srgb WEBGL_debug_renderer_info WEBGL_debug_shaders WEBGL_depth_texture WEBGL_draw_buffers WEBGL_lose_context","webgl1WSIInfo":"EGL_VENDOR: Google Inc. (adapter LUID: 0000000000000000)\nEGL_VERSION: 1.4 (ANGLE 2.1.0.ae3b5a6552ee)\nEGL_EXTENSIONS: EGL_EXT_create_context_robustness EGL_ANGLE_d3d_texture_client_buffer EGL_ANGLE_query_surface_pointer EGL_ANGLE_window_fixed_size EGL_ANGLE_keyed_mutex EGL_ANGLE_surface_orientation EGL_KHR_create_context EGL_EXT_device_query EGL_KHR_image EGL_KHR_image_base EGL_KHR_gl_texture_2D_image EGL_KHR_gl_texture_cubemap_image EGL_KHR_gl_renderbuffer_image EGL_KHR_get_all_proc_addresses EGL_KHR_stream EGL_KHR_stream_consumer_gltexture EGL_NV_stream_consumer_gltexture_yuv EGL_ANGLE_flexible_surface_compatibility EGL_ANGLE_stream_producer_d3d_texture EGL_ANGLE_create_context_webgl_compatibility EGL_CHROMIUM_create_context_bind_generates_resource EGL_EXT_pixel_format_float EGL_KHR_surfaceless_context EGL_ANGLE_display_texture_share_group EGL_ANGLE_create_context_client_arrays EGL_ANGLE_program_cache_control EGL_ANGLE_robust_resource_initialization EGL_ANGLE_create_context_extensions_enabled \nEGL_EXTENSIONS(nullptr): EGL_EXT_client_extensions EGL_EXT_platform_base EGL_EXT_platform_device EGL_ANGLE_platform_angle EGL_ANGLE_platform_angle_d3d EGL_ANGLE_device_creation EGL_ANGLE_device_creation_d3d11 EGL_ANGLE_experimental_present_path EGL_KHR_client_get_all_proc_addresses EGL_ANGLE_explicit_context ","webgl2Renderer":"WebGL creation failed: \n* Refused to create WebGL2 context because of blacklist entry: FEATURE_FAILURE_UNKNOWN_DEVICE_VENDOR","webgl2Version":"-","webgl2DriverExtensions":"-","webgl2Extensions":"-","webgl2WSIInfo":"-","info":{"AzureCanvasBackend":"skia","AzureFallbackCanvasBackend":"cairo","AzureContentBackend":"skia","AzureCanvasAccelerated":0,"ApzWheelInput":1,"ApzDragInput":1,"ApzKeyboardInput":1,"ApzAutoscrollInput":1},"featureLog":{"features":[{"name":"HW_COMPOSITING","description":"Compositing","status":"available","log":[{"type":"default","status":"available"}]},{"name":"D3D11_COMPOSITING","description":"Direct3D11 Compositing","status":"blacklisted","log":[{"type":"default","status":"available"},{"type":"env","status":"blacklisted","message":"#BLOCKLIST_FEATURE_FAILURE_UNKNOWN_DEVICE_VENDOR"}]},{"name":"DIRECT2D","description":"Direct2D","status":"unavailable","log":[{"type":"default","status":"unavailable","message":"Direct2D requires Direct3D 11 compositing"}]},{"name":"D3D11_HW_ANGLE","description":"Direct3D11 hardware ANGLE","status":"disabled","log":[{"type":"default","status":"unavailable","message":"D3D11 compositing is disabled"},{"type":"env","status":"disabled","message":"D3D11 compositing is disabled"}]},{"name":"GPU_PROCESS","description":"GPU Process","status":"blacklisted","log":[{"type":"default","status":"available"},{"type":"env","status":"blacklisted","message":"#BLOCKLIST_FEATURE_FAILURE_UNKNOWN_DEVICE_VENDOR"}]},{"name":"WEBRENDER","description":"WebRender","status":"unavailable","log":[{"type":"default","status":"opt-in","message":"WebRender is an opt-in feature"},{"type":"runtime","status":"unavailable","message":"ANGLE is disabled"}]},{"name":"WEBRENDER_QUALIFIED","description":"WebRender qualified","status":"blocked","log":[{"type":"default","status":"available"},{"type":"env","status":"blocked","message":"No qualified hardware"}]},{"name":"OMTP","description":"Off Main Thread Painting","status":"available","log":[{"type":"default","status":"available"}]}],"fallbacks":[]},"crashGuards":[]},"extensions":[{"name":"PageLoader extension","version":"1.0.32","isActive":true,"id":"[e-mail]"},{"name":"Talos Powers","version":"1.0.14","isActive":true,"id":"[e-mail]"}],"features":[{"name":"Application Update Service Helper","version":"2.0","id":"[e-mail]"},{"name":"Firefox Screenshots","version":"33.0.0","id":"[e-mail]"},{"name":"Form Autofill","version":"1.0","id":"[e-mail]"},{"name":"Photon onboarding","version":"1.0","id":"[e-mail]"},{"name":"Pocket","version":"1.0.5","id":"[e-mail]"},{"name":"Web Compat","version":"2.0.1","id":"[e-mail]"},{"name":"WebCompat Reporter","version":"1.0.0","id":"[e-mail]"}]}JavaScript error: resource:///modules/SavantShieldStudy.jsm, line 171: TypeError: this.addonListener is undefined
23:36:19     INFO -  [Parent 804, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
23:36:19     INFO -  [Child 4092, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
23:36:19     INFO -  [Child 4092, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
23:36:19     INFO -  [Parent 804, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
23:36:19     INFO -  [Child 892, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
23:36:19     INFO -  [Child 892, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
23:36:19     INFO -  [Child 2132, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
23:36:19     INFO -  [Child 2132, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
23:36:19     INFO -  [Parent 804, Gecko_IOThread] WARNING: file z:/build/build/src/ipc/chromium/src/base/process_util_win.cc, line 188
23:36:19     INFO -  console.error: (new Error("Connection closed before committing the transaction.", "resource://gre/modules/Sqlite.jsm", 632))
23:36:19     INFO -  JavaScript error: resource://gre/modules/osfile/osfile_async_front.jsm, line 407: Error: OS.File has been shut down. Rejecting post to DirectoryIterator_prototype_close
23:36:19     INFO -  TEST-INFO | 804: exit 0
23:36:19     INFO -  Browser initialized.
23:36:19     INFO -  Running cycle 1/1 for tp5n test...
23:36:19     INFO -  c:/Program Files/Microsoft Windows Performance Toolkit/xperf: error: NT Kernel Logger: Access is denied. (0x5).
23:36:19     INFO -  extending with xperf!

23:37:53    ERROR -  Traceback (most recent call last):
23:37:53     INFO -    File "Z:\task_1534548474\build\tests\talos\talos/xtalos/parse_xperf.py", line 115, in <module>
23:37:53     INFO -      main()
23:37:53     INFO -    File "Z:\task_1534548474\build\tests\talos\talos/xtalos/parse_xperf.py", line 109, in main
23:37:53     INFO -      **args.__dict__)
23:37:53     INFO -    File "Z:\task_1534548474\build\tests\talos\talos/xtalos/parse_xperf.py", line 93, in stop_from_config
23:37:53     INFO -      run_session_restore_analysis(csv_filename=csv_base, debug=debug, **kwargs)
23:37:53     INFO -    File "Z:\task_1534548474\build\tests\talos\talos/xtalos/parse_xperf.py", line 39, in run_session_restore_analysis
23:37:53     INFO -      output += "%.3f\n" % (interval.get_results()[XPerfAttribute.RESULT])
23:37:53     INFO -    File "Z:\task_1534548474\build\tests\talos\talos\xtalos\xperf_analyzer.py", line 253, in get_results
23:37:53     INFO -      end = self.seen_evtlist[-1]
23:37:53     INFO -  IndexError: list index out of range
23:37:56     INFO -  extending with xperf!
23:37:56     INFO -  TEST-UNEXPECTED-ERROR | tp5n | [Errno 2] No such file or directory: 'etl_output_session_restore_stats.csv'
23:37:56    ERROR -  Traceback (most recent call last):
23:37:56     INFO -    File "Z:\task_1534548474\build\tests\talos\talos\run_tests.py", line 299, in run_tests
23:37:56     INFO -      talos_results.add(mytest.runTest(browser_config, test))
23:37:56     INFO -    File "Z:\task_1534548474\build\tests\talos\talos\ttest.py", line 63, in runTest
23:37:56     INFO -      return self._runTest(browser_config, test_config, setup)
23:37:56     INFO -    File "Z:\task_1534548474\build\tests\talos\talos\ttest.py", line 275, in _runTest
23:37:56     INFO -      else None)
23:37:56     INFO -    File "Z:\task_1534548474\build\tests\talos\talos\results.py", line 95, in add
23:37:56     INFO -      global_counters=self.global_counters
23:37:56     INFO -    File "Z:\task_1534548474\build\tests\talos\talos\results.py", line 333, in __init__
23:37:56     INFO -      self.counters(self.counter_results, self.global_counters)
23:37:56     INFO -    File "Z:\task_1534548474\build\tests\talos\talos\results.py", line 413, in counters
23:37:56     INFO -      self.xperf(global_counters)
23:37:56     INFO -    File "Z:\task_1534548474\build\tests\talos\talos\results.py", line 502, in xperf
23:37:56     INFO -      with open(filename, 'r') as contents:
23:37:56     INFO -  IOError: [Errno 2] No such file or directory: 'etl_output_session_restore_stats.csv'
23:37:56     INFO -  TEST-INFO took 98942ms
23:37:56     INFO -  SUITE-END | took 98s
23:37:56    ERROR - Return code: 2
23:37:56  WARNING - setting return code to 2
23:37:56    ERROR - # TBPL FAILURE #

Comment 12

[(No longer employed by Mozilla) Aaron Klotz]

xperf isn't supposed to be running at the moment, so we can just hold off on landing this until bug 1439588 lands.

Comment 13

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f7d550d783449a155a5681f0db3939bd9ecad58b
Bug 1463483: Add session store analysis to xperf; r=jmaher

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f7d550d78344