1463509 - Alternative Services Support for SOCKS connections

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P3)

Description

[Patrick McManus [:mcmanus]]

Alternate Services is not implemented when behind a proxy. For the general http:// case its not possible, as the proxy is given just the origin name and an Alt-Service needs both a 'route' and an origin.

however, SOCKS and HTTPS connect are actually routes. And these proxies are not aware of http semantics inside the TLS, so they don't need the origin.

This patch adds SOCKS support. SOCKS and Alt-Svc support is particularly interesting for the tor protocol as a way to route to tor protocol .onion native (non-exit) services without changing origins/bookmarks/links.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: Bug 1463509 - SOCKS support for Alternative Services

Review commit: https://reviewboard.mozilla.org/r/245818/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245818/

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8979675 [details]
Bug 1463509 - SOCKS support for Alternative Services

https://reviewboard.mozilla.org/r/245818/#review251972

::: netwerk/base/nsSocketTransport2.cpp:1164
(Diff revision 1)
>          int32_t     port       = (int32_t) mOriginPort;
>          nsCOMPtr<nsIProxyInfo> proxyInfo = mProxyInfo;
>          uint32_t    controlFlags = 0;
>  
>          uint32_t i;
> -        for (i=0; i<mTypeCount; ++i) {
> +        for (i=0; i < mTypeCount; ++i) {

nit: let's space out i=0 since we're here.

::: netwerk/protocol/http/AlternateServices.h:68
(Diff revision 1)
>    static void ProcessHeader(const nsCString &buf, const nsCString &originScheme,
>                              const nsCString &originHost, int32_t originPort,
>                              const nsACString &username, bool privateBrowsing,
>                              nsIInterfaceRequestor *callbacks, nsProxyInfo *proxyInfo,
>                              uint32_t caps, const OriginAttributes &originAttributes);
> +  static bool AcceptableProxy(nsProxyInfo *pi);

Let's add a comment regarding what `acceptable` means in this context, and what we use it for.
Also mention that it returns true when passed a null pointer.

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 8979675 [details]
Bug 1463509 - SOCKS support for Alternative Services

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245818/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c2270d35829d
SOCKS support for Alternative Services r=valentin

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c2270d35829d