1463586 - nestegg: value is outside the range of representable values of type 'unsigned long' in [@ ne_read_block]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Tyson Smith [:tsmith]]

Attachment: testcase.webm

nestegg (test) was build unsing the following config command:
CFLAGS="-fsanitize=integer" CC=clang ./configure --enable-static --disable-shared

https://github.com/kinetiknz/nestegg/blob/fuzzing/src/nestegg.c#L1563

src/nestegg.c:1563:19: runtime error: value 1.84467e+19 is outside the range of representable values of type 'unsigned long'
    #0 0x52f22e in ne_read_block src/nestegg.c:1563:19
    #1 0x52651c in nestegg_read_packet src/nestegg.c:2774:11
    #2 0x50f72d in test test/regress.c:205:9
    #3 0x510f14 in main test/regress.c:298:5
    #4 0x7fd36799d82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)
    #5 0x419a68 in _start (regress+0x419a68)

Comment 1

[Matthew Gregan [:kinetik]]

Similar to bug 1462194 comment 1.  I think we'll replace the timestamp calculations with a version that explicitly saturates.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: GitHub Pull Request

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 9559586 [details] [review]
GitHub Pull Request

Clearing r?, already reviewed upstream.