1463603 - Changes to nsStyleSVGReset cause display: inline-block to become display:block

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, enhancement)

Description

[u480271]

Implementing Bug 1457353 I've run into a bug in the rendering of some ref test reference pages, eg. flexbox justification ref test.

Comment 1

[u480271]

Attachment: test_flexbox_failure_2.xhtml

test case showing the issue. the <div id="bork"> has the wrong display.

Comment 2

[u480271]

Attachment: mFloodColor changes.

MozReview-Commit-ID: GPpqSy5rNEO

Comment 3

[u480271]

Attachment: mStopColor changes.

MozReview-Commit-ID: Dm9HlqSemzD

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1463603 - Ensure modified_reset is set when {mutate,take}_reset_struct is called.

Review commit: https://reviewboard.mozilla.org/r/245990/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245990/

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8979823 [details]
Bug 1463603 - Ensure modified_reset is set when {mutate,take}_reset_struct is called.

https://reviewboard.mozilla.org/r/245990/#review252018

Python's variable scoping rules. :/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3acb2a4a30fe
Ensure modified_reset is set when {mutate,take}_reset_struct is called. r=heycam

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3acb2a4a30fe