Closed
Bug 1463627
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11113 - FormData: Strings from form controls should be converted to USVStrings
Categories
(Core :: DOM: Core & HTML, enhancement, P4)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11113 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/11113 Details from upstream follow. Kent Tamura <tkent@chromium.org> wrote: > FormData: Strings from form controls should be converted to USVStrings > > This CL fixes a regression by crrev.com/560505. > > Before r560505 such strings were converted to USVStrings implicitly > because FromData::Entry stored encoded CStrings, and text encoders > replace unpaired surrogates with U+FFFD. Since r560505 we don't apply > text encoding in FormData::Entry, and need to convert strings to > USVStrings explicitly. > > This CL also adds DCHECKs to FormData::Entry constructors. > > Bug: 845744 > Change-Id: I9893848f4e32fbe3c0c7a8f787584fbbb8ba8e87 > > Reviewed-on: https://chromium-review.googlesource.com/1067560 > WPT-Export-Revision: 442a3f5c1131d2b0474ed658f7635e3d91a937e1
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=81a582a6396db1533956f3e66361be453cf9c4ce
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b701b88a450971774171e8378bbe35ecb67f2dd
Assignee | ||
Comment 3•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=393a0661f28b1edf097830a3a0c5cec7cb18d938
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ef474e6cce0 [wpt PR 11113] - FormData: Strings from form controls should be converted to USVStrings, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/0b9d728e905d [wpt PR 11113] - Update wpt metadata, a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9ef474e6cce0 https://hg.mozilla.org/mozilla-central/rev/0b9d728e905d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•