1463673 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[Mark Banner (:standard8)]

This is continuing roll-out of require-expected-throws-or-rejects as per bug 1452706.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1463673 - Member expressions should also be allowed as expected arguments to Assert.throws/rejects.

Review commit: https://reviewboard.mozilla.org/r/246040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246040/

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1463673 - Add the expected argument to Assert.throws/rejects for toolkit/components/telemetry.

Review commit: https://reviewboard.mozilla.org/r/246042/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246042/

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1463673 - Add the expected argument to Assert.throws/rejects for toolkit/components/places.

Review commit: https://reviewboard.mozilla.org/r/246044/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246044/

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1463673 - Add the expected argument to Assert.throws/rejects for various tests in toolkit/.

Review commit: https://reviewboard.mozilla.org/r/246046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246046/

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1463673 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/.

Review commit: https://reviewboard.mozilla.org/r/246048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246048/

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8979856 [details]
Bug 1463673 - Member expressions should also be allowed as expected arguments to Assert.throws/rejects.

https://reviewboard.mozilla.org/r/246040/#review252284

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8979859 [details]
Bug 1463673 - Add the expected argument to Assert.throws/rejects for various tests in toolkit/.

https://reviewboard.mozilla.org/r/246046/#review252286

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 8979860 [details]
Bug 1463673 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/.

https://reviewboard.mozilla.org/r/246048/#review252288

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 8979858 [details]
Bug 1463673 - Add the expected argument to Assert.throws/rejects for toolkit/components/places.

https://reviewboard.mozilla.org/r/246044/#review252534

Comment 10

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8979857 [details]
Bug 1463673 - Add the expected argument to Assert.throws/rejects for toolkit/components/telemetry.

https://reviewboard.mozilla.org/r/246042/#review252942

Thanks!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4bfc66b1fb9
Member expressions should also be allowed as expected arguments to Assert.throws/rejects. r=mossop
https://hg.mozilla.org/integration/autoland/rev/015e8f74e973
Add the expected argument to Assert.throws/rejects for toolkit/components/telemetry. r=gfritzsche
https://hg.mozilla.org/integration/autoland/rev/c9f558e4282c
Add the expected argument to Assert.throws/rejects for toolkit/components/places. r=mak
https://hg.mozilla.org/integration/autoland/rev/1350bcc2983e
Add the expected argument to Assert.throws/rejects for various tests in toolkit/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/d73afee801c0
Enable ESLint rule require-expected-throws-or-rejects for toolkit/. r=mossop

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d4bfc66b1fb9
https://hg.mozilla.org/mozilla-central/rev/015e8f74e973
https://hg.mozilla.org/mozilla-central/rev/c9f558e4282c
https://hg.mozilla.org/mozilla-central/rev/1350bcc2983e
https://hg.mozilla.org/mozilla-central/rev/d73afee801c0