Enable ESLint rule require-expected-throws-or-rejects for toolkit/

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(5 attachments)

This is continuing roll-out of require-expected-throws-or-rejects as per bug 1452706.
Comment hidden (mozreview-request)

Comment 6

a year ago
mozreview-review
Comment on attachment 8979856 [details]
Bug 1463673 - Member expressions should also be allowed as expected arguments to Assert.throws/rejects.

https://reviewboard.mozilla.org/r/246040/#review252284
Attachment #8979856 - Flags: review?(dtownsend) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8979859 [details]
Bug 1463673 - Add the expected argument to Assert.throws/rejects for various tests in toolkit/.

https://reviewboard.mozilla.org/r/246046/#review252286
Attachment #8979859 - Flags: review?(dtownsend) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8979860 [details]
Bug 1463673 - Enable ESLint rule require-expected-throws-or-rejects for toolkit/.

https://reviewboard.mozilla.org/r/246048/#review252288
Attachment #8979860 - Flags: review?(dtownsend) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8979858 [details]
Bug 1463673 - Add the expected argument to Assert.throws/rejects for toolkit/components/places.

https://reviewboard.mozilla.org/r/246044/#review252534
Attachment #8979858 - Flags: review?(mak77) → review+

Comment 10

a year ago
mozreview-review
Comment on attachment 8979857 [details]
Bug 1463673 - Add the expected argument to Assert.throws/rejects for toolkit/components/telemetry.

https://reviewboard.mozilla.org/r/246042/#review252942

Thanks!
Attachment #8979857 - Flags: review?(gfritzsche) → review+

Comment 11

a year ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4bfc66b1fb9
Member expressions should also be allowed as expected arguments to Assert.throws/rejects. r=mossop
https://hg.mozilla.org/integration/autoland/rev/015e8f74e973
Add the expected argument to Assert.throws/rejects for toolkit/components/telemetry. r=gfritzsche
https://hg.mozilla.org/integration/autoland/rev/c9f558e4282c
Add the expected argument to Assert.throws/rejects for toolkit/components/places. r=mak
https://hg.mozilla.org/integration/autoland/rev/1350bcc2983e
Add the expected argument to Assert.throws/rejects for various tests in toolkit/. r=mossop
https://hg.mozilla.org/integration/autoland/rev/d73afee801c0
Enable ESLint rule require-expected-throws-or-rejects for toolkit/. r=mossop
No longer depends on: 1465385
You need to log in before you can comment on or make changes to this bug.