14637 - Sidebar crashes in table

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P1)

Description

[Eric Vaughan]

Side bar crashed windows NT when dragging the panels up or down.

To reproduce:

1) Grab the titled of the middle sidebar panel.
2) Drag down

This happens because there is a table in the sidebar with nothing inside it. I
believe it is the flash panel.

nsDebug::Assertion(const char * 0x018a84a0, const char * 0x018a8494, const char
* 0x018a8454, int 90) line 181 + 13 bytes
FixedTableLayoutStrategy::AssignPreliminaryColumnWidths(int 1755) line 90 + 32
bytes
BasicTableLayoutStrategy::Initialize(nsSize * 0x00000000, int 1, int 1755) line
79
nsTableFrame::BalanceColumnWidths(nsIPresContext & {...}, const
nsHTMLReflowState & {...}, const nsSize & {...}, nsSize * 0x00000000) line 3842
nsTableFrame::Reflow(nsTableFrame * const 0x02e33754, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 2260
nsTreeFrame::Reflow(nsTreeFrame * const 0x02e33754, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 325 + 25 bytes
nsContainerFrame::ReflowChild(nsIFrame * 0x02e33750, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 372 + 28 bytes
nsTableOuterFrame::Reflow(nsTableOuterFrame * const 0x02e33874, nsIPresContext &
{...}, nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned
int & 0) line 906 + 37 bytes
nsBoxFrame::FlowChildAt(nsIFrame * 0x02e33870, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0,
nsCalculatedBoxInfo & {...}, int & 0, nsString & {...}) line 1051
nsBoxFrame::FlowChildren(nsIPresContext & {...}, nsHTMLReflowMetrics & {...},
const nsHTMLReflowState & {...}, unsigned int & 0, nsRect & {...}) line 682
nsBoxFrame::Reflow(nsBoxFrame * const 0x02354e4c, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 517
nsContainerFrame::ReflowChild(nsIFrame * 0x02354e48, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 372 + 28 bytes
RootFrame::Reflow(RootFrame * const 0x02e304d4, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 330
nsContainerFrame::ReflowChild(nsIFrame * 0x02e304d0, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 372 + 28 bytes
ViewportFrame::Reflow(ViewportFrame * const 0x02e2add4, nsIPresContext & {...},
nsHTMLReflowMetrics & {...}, const nsHTMLReflowState & {...}, unsigned int & 0)
line 516
PresShell::ResizeReflow(PresShell * const 0x02981ab0, int 1755, int 1875) line
949
PresShell::ResizeReflow(PresShell * const 0x02981ab4, nsIView * 0x02980590, int
1755, int 1875) line 2132
nsViewManager::SetWindowDimensions(nsViewManager * const 0x02980760, int 1755,
int 1875) line 366
nsViewManager::DispatchEvent(nsViewManager * const 0x02980760, nsGUIEvent *
0x0012e2e0, nsEventStatus & nsEventStatus_eIgnore) line 1527

Comment 1

[Steve Lamm]

Having an empty tree should be legal. I would assign this bug to hyatt, but he
isn't typing anymore. Maybe I can type while he tells me what to do.

Comment 2

[don]

Steve, do we need to fix this for M10?

Comment 3

[Steve Lamm]

Pavlov typed in a fix for hyatt.
Marking fixed.

Comment 4

[Paul MacQuiddy]

verified with M10 builds

Comment 5

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/64037889a442
[fenix] For https://github.com/mozilla-mobile/fenix/issues/14637 - Fix sitePermissionsFeature breaking change + AC bump (https://github.com/mozilla-mobile/fenix/pull/16229)