Closed Bug 1463794 Opened 2 years ago Closed 2 years ago

Mozilla-created WPT reftests for shape-outside should be hosted in layout/reftests/w3c-css/submitted/

Categories

(Core :: Layout: Floats, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bradwerth, Assigned: bradwerth)

References

Details

Attachments

(1 file)

Bug 1460041 and possibly other bugs introduced new WPT reftests directly into the tree at testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1. That location is not a source of truth -- those tests are imported from layout/reftests/w3c-css/submitted/.

Audit the tests in testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1 and ensure all of them have their originals in layout/reftests/w3c-css/submitted/.
I already pushed a fix to inbound in bug 1460041
It got backed out; could you fix?
Attachment #8980078 - Flags: review?(dbaron)
Comment on attachment 8980078 [details]
Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

https://reviewboard.mozilla.org/r/246234/#review252340

Looks fine, except based on my push earlier I think 056 will show failures.
Attachment #8980078 - Flags: review?(dbaron) → review+
(In reply to David Baron :dbaron: ⌚UTC-7 from comment #5)
> Comment on attachment 8980078 [details]
> Bug 1463794: Move new WPT reftests to correct source-of-truth directory.
> 
> https://reviewboard.mozilla.org/r/246234/#review252340
> 
> Looks fine, except based on my push earlier I think 056 will show failures.

Failure is in all three tests, because (it appears) the Ahem font doesn't load for the layout/reftests/w3c-css/submitted/ directory. I'm trying to figure out a suitable alternative.
You need an @font-face rules that loads the Ahem font.  See, e.g., variables/variable-font-face-02.html or many others.
Priority: -- → P3
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c19f0dedfb15
Move new WPT reftests to correct source-of-truth directory. r=dbaron
Pushed by bwerth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41590914f85e
Move new WPT reftests to correct source-of-truth directory. r=dbaron+3881
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/11157 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/41590914f85e
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Upstream PR merged
Flags: needinfo?(bwerth)
You need to log in before you can comment on or make changes to this bug.