1463794 - Mozilla-created WPT reftests for shape-outside should be hosted in layout/reftests/w3c-css/submitted/

Status: RESOLVED FIXED

(Core :: Layout: Floats, defect, P3)

Description

[Brad Werth [:bradwerth]]

Bug 1460041 and possibly other bugs introduced new WPT reftests directly into the tree at testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1. That location is not a source of truth -- those tests are imported from layout/reftests/w3c-css/submitted/.

Audit the tests in testing/web-platform/tests/css/vendor-imports/mozilla/mozilla-central-reftests/shapes1 and ensure all of them have their originals in layout/reftests/w3c-css/submitted/.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I already pushed a fix to inbound in bug 1460041

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It got backed out; could you fix?

Comment 3

[Brad Werth [:bradwerth]]

Attachment: Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

Review commit: https://reviewboard.mozilla.org/r/246234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246234/

Comment 4

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4bfc25fe7a1d384fd11b02a543c9c9cf1f31794a

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8980078 [details]
Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

https://reviewboard.mozilla.org/r/246234/#review252340

Looks fine, except based on my push earlier I think 056 will show failures.

Comment 6

[Brad Werth [:bradwerth]]

Comment on attachment 8980078 [details]
Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246234/diff/1-2/

Comment 7

[Brad Werth [:bradwerth]]

Comment on attachment 8980078 [details]
Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246234/diff/2-3/

Comment 8

[Brad Werth [:bradwerth]]

(In reply to David Baron :dbaron: ⌚UTC-7 from comment #5)
> Comment on attachment 8980078 [details]
> Bug 1463794: Move new WPT reftests to correct source-of-truth directory.
> 
> https://reviewboard.mozilla.org/r/246234/#review252340
> 
> Looks fine, except based on my push earlier I think 056 will show failures.

Failure is in all three tests, because (it appears) the Ahem font doesn't load for the layout/reftests/w3c-css/submitted/ directory. I'm trying to figure out a suitable alternative.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

You need an @font-face rules that loads the Ahem font.  See, e.g., variables/variable-font-face-02.html or many others.

Comment 10

[Brad Werth [:bradwerth]]

Comment on attachment 8980078 [details]
Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246234/diff/3-4/

Comment 11

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3286d9c09b8394b5a48168ec9c257ef7b7579c38

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c19f0dedfb15
Move new WPT reftests to correct source-of-truth directory. r=dbaron

Comment 13

[Noemi Erli[:noemi_erli]]

Backed out changeset c19f0dedfb15 (bug 1463794) for reftest failures in build/tests/reftest/tests/layout/reftests/w3c-css/submitted/shapes1/shape-outside-circle-056.html on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c19f0dedfb15e733e2469eb092af59225c3ef63a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=180016408

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=180016408&repo=autoland&lineNumber=16312

Backout: https://hg.mozilla.org/integration/autoland/rev/fae06a27c30119754a4522f9ec21d254d34cfc80

Comment 14

[Brad Werth [:bradwerth]]

Comment on attachment 8980078 [details]
Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246234/diff/4-5/

Comment 15

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c57580f466d04ab0b1799a0de8dfe6eb756ef2bb

Comment 16

[Brad Werth [:bradwerth]]

Comment on attachment 8980078 [details]
Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246234/diff/5-6/

Comment 17

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=63ed3565ffebcbcbc6ce4aad845c7d8fee2539f7

Comment 18

[Brad Werth [:bradwerth]]

Comment on attachment 8980078 [details]
Bug 1463794: Move new WPT reftests to correct source-of-truth directory.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246234/diff/6-7/

Comment 19

[Brad Werth [:bradwerth]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=87aac5e16f8e7f67c0122fbdfef3539666407d73

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41590914f85e
Move new WPT reftests to correct source-of-truth directory. r=dbaron+3881

Comment 21

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/11157 for changes under testing/web-platform/tests

Comment 22

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 23

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/41590914f85e

Comment 24

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged