1463802 - Shadow in http://sinz.org/Clock/ is cut off with WebRender.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Emilio Cobos Álvarez (:emilio)]

Only the upper half of the inset shadow on the clock circle is shown.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Batch updating status flags based on WR schedule - please adjust if needed.

Comment 2

[Aria Beingessner [:Gankra]]

str: 

data:text/html,<div style="width: 80vmin; height: 80vmin; padding: 6vmin;"><div class="inner" style="border-radius: 100%;box-shadow: 0px 0px 18px rgba(24, 24, 24, 0.7) inset;height: 100%;"></div></div>

Comment 3

[Aria Beingessner [:Gankra]]

better str:

<div style="height: 133.6px; width: 133.6px;"><div style="box-shadow: 0px 0px 18px inset; height: 100%;"></div></div>

(the failure seems to come and go depending on height, so might not be portable)

Comment 4

[Glenn Watson [:gw]]

This will be fixed when https://github.com/servo/webrender/pull/2824 lands in Gecko + WR.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot of clock on macOS try build c6aba0f836c7

So in the latest WR try build the shadow is fixed, but there's a white bounding-rect thing in the corner. See attached screenshot.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Hm, never mind. That white bounding rect occurs in current Nightly as well, just not if you have the sidebar open. I'll spin that out into another bug.

Comment 7

[Darkspirit]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> So in the latest WR try build the shadow is fixed, but there's a white bounding-rect thing in the corner.

That reminds me of https://github.com/servo/webrender/issues/2754#issuecomment-396653493.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #5)
> Created attachment 8986741 [details]
> Screenshot of clock on macOS try build c6aba0f836c7
> 
> So in the latest WR try build the shadow is fixed, but there's a white
> bounding-rect thing in the corner. See attached screenshot.

I don't see that on my machine, fwiw.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Filed bug 1470133 for it. I only see it on mac, so maybe not so important.

Comment 10

[Kartikaya Gupta (email:[e-mail])]

I reduced the clock page and turned it into a reftest. It's slightly fuzzy for me on macOS and windows locally, but it passes without WR and fails with WR. Presumably it will pass (although fuzziness might need tweaking) with the WR update.

Try push (based on current m-c) is at https://treeherder.mozilla.org/#/jobs?repo=try&revision=771f72c79fd7d833058761c6dc195a14f0948a41

Comment 11

[Kartikaya Gupta (email:[e-mail])]

I had also pushed a try push with the reftest on top of the WR update to figure out how much fuzz is needed in the "fixed in webrender" scenario, that's at https://treeherder.mozilla.org/#/jobs?repo=try&revision=82ccc485eac16955c9c97e772fd144c75b32092f

I have the fuzz numbers now so I'll put up the patch. And another try push just to verify it's green everywhere: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49134002f60832759f2ac8bd9861dd27e42d06e

Comment 12

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1463802 - Add reftest.

Review commit: https://reviewboard.mozilla.org/r/252164/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252164/

Comment 13

[Aria Beingessner [:Gankra]]

Comment on attachment 8986934 [details]
Bug 1463802 - Add reftest.

https://reviewboard.mozilla.org/r/252164/#review258800

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/caadd3c8d735
Add reftest. r=Gankro

Comment 15

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/caadd3c8d735