1463826 - [FxA Messages] Implement FxA device commands

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, enhancement, P1)

Description

[Justin D'Arcangelo [:justindarc]]

Implement the following two FxA Messages API calls in our FxA client:

- POST /account/devices/messages
- GET  /account/devices/messages

Reference documentation:

https://docs.google.com/document/d/1kOf82sHrIDyPYa_VKzOFiMeIatBqdPg4E2YIIYO1SJ0/edit#

Desktop client:

https://searchfox.org/mozilla-central/source/services/fxaccounts/FxAccountsClient.jsm

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8980033 [details] [review]
GitHub Pull Request

Removing flag for review for the time being since I'm going to be adding some more commits to this first.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Renaming this bug to better align with the equivalent desktop Bug 1466933.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8980033 [details] [review]
GitHub Pull Request

Hey James, we pulled your name out of the hat today and you're the lucky one who gets to review this mess :-D

But for real, this PR isn't done yet, but just looking for some feedback now before I get much further with it. This PR will ultimately be the iOS equivalent of :eoger's patch in Bug 1466933. I think it is currently about 70-80% parity with it. My next steps (maybe not by the time you look at this) will be to actually persist/retrieve the generated keys to/from the Keychain.

Thanks man.

Comment 5

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8980033 [details] [review]
GitHub Pull Request

Comments in the PR.

Comment 6

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8980033 [details] [review]
GitHub Pull Request

Ready for review now :-)

Comment 23

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8980033 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub.

Comment 24

[Justin D'Arcangelo [:justindarc]]

Bumping to v14.0 now that it has been added in Bugzilla.

Comment 25

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/3299e02fe72f9fa7f035b9123481797bd33ef906