1463860 - In "Find in Content" bar, if "Whole Words" is enabled, typing in the search box plays error tone for each key typed

Status: RESOLVED FIXED

(Toolkit :: Find Toolbar, defect, P1)

Description

[Eric Shepherd [:sheppy]]

While using the find in content bar at the bottom of the Firefox window, if you have "whole words" enabled, typing in the search box causes the system's error beep to play with every keystroke until there's at least one match. This is incredibly annoying, especially if you're looking for a specific word -- getting an error for each keystroke while typing your search term is an unnecessary distraction.

Comment 1

[Mike de Boer [:mikedeboer]]

This has been annoying me too :) Thanks for filing - I'll get back to this asap.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1463860 - Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much.

Review commit: https://reviewboard.mozilla.org/r/256786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/256786/

Comment 3

[(no longer active)]

Comment on attachment 8991868 [details]
Bug 1463860 - Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much.

https://reviewboard.mozilla.org/r/256786/#review263738

Hah, fair enough!

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to :Ehsan Akhgari from comment #3)
> Hah, fair enough!

;-) Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/16b902cbcf26
Don't play a beep when the find string is not find when Whole Word matching is enabled; it simply beeps too much. r=Ehsan

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/16b902cbcf26